Skip to content

Commit da5381d

Browse files
committed
Require older yapf
With 0.29.0, we ran into google/yapf#781, which made pylint unhappy and makes the arg list harder to read.
1 parent 02834b2 commit da5381d

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@ before_install:
3434
- "if [[ $RUN_SNYK && $SNYK_TOKEN ]]; then sudo apt-get install -y nodejs; npm install -g snyk; fi"
3535
install:
3636
- pip install -r requirements.txt
37-
- pip install requests_mock pylint coveralls yapf
37+
# We require yapf 0.28.0 to work around https://github.com/google/yapf/issues/781
38+
# If that issue is resolved, we should remove the version constraint.
39+
- pip install requests_mock pylint coveralls yapf==0.28.0
3840
- "if [[ $RUN_SNYK && $SNYK_TOKEN ]]; then snyk test --org=maxmind; fi"
3941
script:
4042
- coverage run --source=geoip2 setup.py test

0 commit comments

Comments
 (0)