Minor clean-up. Made several things public again.

Author: oschwald

MaxMind.Db/Buffer.cs

@@ -44,6 +44,26 @@ internal BigInteger ReadBigInteger(long offset, int size)
             return new BigInteger(buffer);
         }
 
+        /// <summary>
+        ///     Read a double from the buffer.
+        /// </summary>
+        internal double ReadDouble(long offset)
+        {
+            var buffer = Read(offset, 8);
+            Array.Reverse(buffer);
+            return BitConverter.ToDouble(buffer, 0);
+        }
+
+        /// <summary>
+        ///     Read a float from the buffer.
+        /// </summary>
+        internal float ReadFloat(long offset)
+        {
+            var buffer = Read(offset, 4);
+            Array.Reverse(buffer);
+            return BitConverter.ToSingle(buffer, 0);
+        }
+
         /// <summary>
         ///     Read an integer from the buffer.
         /// </summary>

MaxMind.Db/Decoder.cs

@@ -236,9 +236,7 @@ private double DecodeDouble(Type expectedType, long offset, int size)
             if (size != 8)
                 throw new InvalidDatabaseException("The MaxMind DB file's data section contains bad data: "
                                                    + "invalid size of double.");
-            var buffer = _database.Read(offset, size);
-            Array.Reverse(buffer);
-            return BitConverter.ToDouble(buffer, 0);
+            return _database.ReadDouble(offset);
         }
 
         /// <summary>
@@ -252,9 +250,7 @@ private float DecodeFloat(Type expectedType, long offset, int size)
             if (size != 4)
                 throw new InvalidDatabaseException("The MaxMind DB file's data section contains bad data: "
                                                    + "invalid size of float.");
-            var buffer = _database.Read(offset, size);
-            Array.Reverse(buffer);
-            return BitConverter.ToSingle(buffer, 0);
+            return _database.ReadFloat(offset);
         }
 
         /// <summary>

MaxMind.Db/DeserializationException.cs

@@ -19,7 +19,7 @@ public sealed class DeserializationException : Exception
         ///     Construct a DeserializationException
         /// </summary>
         /// <param name="message"></param>
-        internal DeserializationException(string message)
+        public DeserializationException(string message)
             : base(message)
         {
         }
@@ -29,7 +29,7 @@ internal DeserializationException(string message)
         /// </summary>
         /// <param name="message"></param>
         /// <param name="innerException">The underlying exception that caused this one.</param>
-        private DeserializationException(string message, Exception innerException)
+        public DeserializationException(string message, Exception innerException)
             : base(message, innerException)
         {
         }

MaxMind.Db/InvalidDatabaseException.cs

@@ -17,7 +17,7 @@ public sealed class InvalidDatabaseException : Exception
         ///     Initializes a new instance of the <see cref="InvalidDatabaseException" /> class.
         /// </summary>
         /// <param name="message">A message that describes the error.</param>
-        internal InvalidDatabaseException(string message)
+        public InvalidDatabaseException(string message)
             : base(message)
         {
         }
@@ -31,7 +31,7 @@ internal InvalidDatabaseException(string message)
         ///     <paramref name="innerException" /> parameter is not a null reference, the current exception is raised in a catch
         ///     block that handles the inner exception.
         /// </param>
-        private InvalidDatabaseException(string message, Exception innerException)
+        public InvalidDatabaseException(string message, Exception innerException)
             : base(message, innerException)
         {
         }

MaxMind.Db/MaxMind.Db.csproj

@@ -46,6 +46,7 @@
     <WarningLevel>4</WarningLevel>
     <CodeAnalysisRuleSet>MaxMind.Db.ruleset</CodeAnalysisRuleSet>
     <Prefer32Bit>false</Prefer32Bit>
+    <RunCodeAnalysis>true</RunCodeAnalysis>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' ">
     <DebugType>pdbonly</DebugType>
@@ -59,6 +60,7 @@
     <RunCodeAnalysis>true</RunCodeAnalysis>
     <CodeAnalysisRuleSet>MaxMind.Db.ruleset</CodeAnalysisRuleSet>
     <Prefer32Bit>false</Prefer32Bit>
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
   </PropertyGroup>
   <PropertyGroup Condition=" '$(Configuration)|$(Platform)' == 'Debug|x86' ">
     <DebugSymbols>true</DebugSymbols>

MaxMind.Db/ParameterAttribute.cs

@@ -15,14 +15,14 @@ public sealed class ParameterAttribute : Attribute
         /// <summary>
         ///     The name to use for the property.
         /// </summary>
-        internal string ParameterName { get; }
+        public string ParameterName { get; }
 
         /// <summary>
         ///     Whether to create the object even if the key is not present in
         ///     the database. If this is false, the default value will be used
         ///     (null for nullable types).
         /// </summary>
-        internal bool AlwaysCreate { get; }
+        public bool AlwaysCreate { get; }
 
         /// <summary>
         ///     Create a new instance of <code>ParameterAttribute</code>.

MaxMind.Db/Properties/AssemblyInfo.cs

@@ -44,7 +44,7 @@
 
 [assembly: AssemblyVersion("2.0.0")]
 [assembly: AssemblyFileVersion("2.0.0")]
-[assembly: AssemblyInformationalVersion("2.0.0-beta1")]
+[assembly: AssemblyInformationalVersion("2.0.0-beta2")]
 [assembly: InternalsVisibleTo("MaxMind.Db.Test,PublicKey=" +
                               "0024000004800000940000000602000000240000525341310004000001000100e30b6e4a9425b1" +
                               "617ffc8bdf79801e67a371f9f650db860dc0dfff92cb63258765a0955c6fcde1da78dbaf5bf84d" +