Rename BadVersionException to InvalidNetworkException

Author: faktas2

…/com/maxmind/db/BadVersionException.java …/maxmind/db/InvalidNetworkException.javasrc/main/java/com/maxmind/db/BadVersionException.java renamed to src/main/java/com/maxmind/db/InvalidNetworkException.java src/main/java/com/maxmind/db/BadVersionException.java renamed to src/main/java/com/maxmind/db/InvalidNetworkException.java

@@ -2,8 +2,8 @@
 
 import java.net.InetAddress;
 
-public class BadVersionException extends Exception {
-    public BadVersionException(InetAddress ip) {
+public class InvalidNetworkException extends Exception {
+    public InvalidNetworkException(InetAddress ip) {
         super("you attempted to use an IPv6 network in an IPv4-only database: " + ip.toString());
     }
 }

src/main/java/com/maxmind/db/Reader.java

@@ -206,12 +206,12 @@ record = this.readNode(buffer, record, bit);
      * SkipAliasedNetworks option.
      * 
      * @return Networks The Networks iterator.
-     * @throws BadVersionException Exception for using an IPv6 network in ipv4-only database.
+     * @throws InvalidNetworkException Exception for using an IPv6 network in ipv4-only database.
      * @throws ClosedDatabaseException Exception for a closed databased.
      * @throws InvalidDatabaseException Exception for an invalid database.
      */
     public Networks networks() throws 
-        BadVersionException, ClosedDatabaseException, InvalidDatabaseException {
+        InvalidNetworkException, ClosedDatabaseException, InvalidDatabaseException {
         return this.networks(true);
     }
 
@@ -224,12 +224,12 @@ public Networks networks() throws
      * 
      * @param skipAliasedNetworks Enable skipping aliased networks.
      * @return Networks The Networks iterator.
-     * @throws BadVersionException Exception for using an IPv6 network in ipv4-only database.
+     * @throws InvalidNetworkException Exception for using an IPv6 network in ipv4-only database.
      * @throws ClosedDatabaseException Exception for a closed databased.
      * @throws InvalidDatabaseException Exception for an invalid database.
      */
     public Networks networks(boolean skipAliasedNetworks) throws 
-        BadVersionException, ClosedDatabaseException, InvalidDatabaseException {
+        InvalidNetworkException, ClosedDatabaseException, InvalidDatabaseException {
         try {
             InetAddress ipv4 = InetAddress.getByAddress(new byte[4]);
             InetAddress ipv6 = InetAddress.getByAddress(new byte[16]);
@@ -289,15 +289,15 @@ private int findIpV4StartNode(ByteBuffer buffer)
      * @param network Specifies the network to be iterated.
      * @param skipAliasedNetworks Boolean for skipping aliased networks.
      * @return Networks
-     * @throws BadVersionException Exception for using an IPv6 network in ipv4-only database.
+     * @throws InvalidNetworkException Exception for using an IPv6 network in ipv4-only database.
      * @throws ClosedDatabaseException Exception for a closed databased.
      * @throws InvalidDatabaseException Exception for an invalid database.
      */
     public <T> Networks<T> networksWithIn(Network network, boolean skipAliasedNetworks) 
-        throws BadVersionException, ClosedDatabaseException, InvalidDatabaseException {
+        throws InvalidNetworkException, ClosedDatabaseException, InvalidDatabaseException {
         InetAddress networkAddress = network.getNetworkAddress();
         if (this.metadata.getIpVersion() == 4 && networkAddress instanceof Inet6Address) {
-            throw new BadVersionException(networkAddress);
+            throw new InvalidNetworkException(networkAddress);
         }
 
         byte[] ipBytes = networkAddress.getAddress();

src/test/java/com/maxmind/db/ReaderTest.java

@@ -79,7 +79,7 @@ static class GetRecordTest {
     }
 
     @Test
-    public void testNetworks() throws IOException, InvalidDatabaseException, BadVersionException {
+    public void testNetworks() throws IOException, InvalidDatabaseException, InvalidNetworkException {
         for (long recordSize : new long[] {24, 28, 32}) {
             for (int ipVersion : new int[] {4, 6}) {
                 File file = getFile("MaxMind-DB-test-ipv" + ipVersion + "-" + recordSize + ".mmdb");
@@ -107,7 +107,7 @@ public void testNetworks() throws IOException, InvalidDatabaseException, BadVers
     }
 
     @Test
-    public void testNetworksWithInvalidSearchTree() throws IOException, BadVersionException{
+    public void testNetworksWithInvalidSearchTree() throws IOException, InvalidNetworkException{
         File file = getFile("MaxMind-DB-test-broken-search-tree-24.mmdb");
         Reader reader = new Reader(file);
 
@@ -328,7 +328,7 @@ public networkTest(String network,  int prefix,String database, String[] expecte
     };
 
     @Test
-    public void testNetworksWithin() throws IOException, BadVersionException{
+    public void testNetworksWithin() throws IOException, InvalidNetworkException{
         for(networkTest test : tests){
             for(int recordSize : new int[]{24, 28, 32}){
                 File file = getFile("MaxMind-DB-test-"+test.database+"-"+recordSize+".mmdb");
@@ -368,7 +368,7 @@ public void testNetworksWithin() throws IOException, BadVersionException{
     };
 
     @Test
-    public void testGeoIPNetworksWithin() throws IOException, BadVersionException{
+    public void testGeoIPNetworksWithin() throws IOException, InvalidNetworkException{
         for (networkTest test : geoipTests){
             File file = getFile(test.database);
             Reader reader = new Reader(file);