Skip to content

Commit db8494b

Browse files
oschwaldclaude
andcommitted
Update collections to use modern factory methods
Replaces Arrays.asList() with List.of() for creating immutable lists and updates empty array initialization to use modern syntax. This improves performance and readability. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
1 parent 72ab13a commit db8494b

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

src/main/java/com/maxmind/db/Networks.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public final class Networks<T> implements Iterator<DatabaseRecord<T>> {
3232
*/
3333
Networks(Reader reader, boolean includeAliasedNetworks, Class<T> typeParameterClass)
3434
throws ClosedDatabaseException {
35-
this(reader, includeAliasedNetworks, new NetworkNode[]{}, typeParameterClass);
35+
this(reader, includeAliasedNetworks, new NetworkNode[0], typeParameterClass);
3636
}
3737

3838
/**

src/test/java/com/maxmind/db/ReaderTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -555,12 +555,12 @@ private void testDecodingTypesIntoModelObject(Reader reader, boolean booleanValu
555555

556556
assertEquals("unicode! ☯ - ♫", model.utf8StringField);
557557

558-
List<Long> expectedArray = new ArrayList<>(Arrays.asList(
558+
List<Long> expectedArray = new ArrayList<>(List.of(
559559
(long) 1, (long) 2, (long) 3
560560
));
561561
assertEquals(expectedArray, model.arrayField);
562562

563-
List<Long> expectedArray2 = new ArrayList<>(Arrays.asList(
563+
List<Long> expectedArray2 = new ArrayList<>(List.of(
564564
(long) 7, (long) 8, (long) 9
565565
));
566566
assertEquals(expectedArray2, model.mapField.mapXField.arrayXField);
@@ -675,12 +675,12 @@ private void testDecodingTypesIntoModelObjectBoxed(Reader reader, boolean boolea
675675

676676
assertEquals("unicode! ☯ - ♫", model.utf8StringField);
677677

678-
List<Long> expectedArray = new ArrayList<>(Arrays.asList(
678+
List<Long> expectedArray = new ArrayList<>(List.of(
679679
(long) 1, (long) 2, (long) 3
680680
));
681681
assertEquals(expectedArray, model.arrayField);
682682

683-
List<Long> expectedArray2 = new ArrayList<>(Arrays.asList(
683+
List<Long> expectedArray2 = new ArrayList<>(List.of(
684684
(long) 7, (long) 8, (long) 9
685685
));
686686
assertEquals(expectedArray2, model.mapField.mapXField.arrayXField);
@@ -785,7 +785,7 @@ private void testDecodingTypesIntoModelWithList(Reader reader)
785785
throws IOException {
786786
TestModelList model = reader.get(InetAddress.getByName("::1.1.1.0"), TestModelList.class);
787787

788-
assertEquals(Arrays.asList((long) 1, (long) 2, (long) 3), model.arrayField);
788+
assertEquals(List.of((long) 1, (long) 2, (long) 3), model.arrayField);
789789
}
790790

791791
static class TestModelList {
@@ -1235,7 +1235,7 @@ private void testMetadata(Reader reader, int ipVersion, long recordSize) {
12351235
assertEquals(ipVersion, metadata.getIpVersion());
12361236
assertEquals("Test", metadata.getDatabaseType());
12371237

1238-
List<String> languages = new ArrayList<>(Arrays.asList("en", "zh"));
1238+
List<String> languages = new ArrayList<>(List.of("en", "zh"));
12391239

12401240
assertEquals(languages, metadata.getLanguages());
12411241

0 commit comments

Comments
 (0)