Skip to content

Commit 26d3720

Browse files
committed
Update plan.md to include source-method configuration
- Add source-method: pre-packaged-source to composer.json example - Document that this field is required for PIE to use pre-packaged source - Add link to MongoDB extension implementation
1 parent cdff74e commit 26d3720

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

plan.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,15 @@ Set up a new extension repository (`MaxMind-DB-Reader-php-ext`) that uses this r
77

88
PIE downloads source code as ZIP archives from Composer/GitHub, which don't include git submodule contents. To work around this limitation, we use PIE's built-in support for **pre-packaged source archives**:
99

10+
- Set `"source-method": "pre-packaged-source"` in the `php-ext` section of composer.json
1011
- The release script creates a tarball: `php_maxminddb-{version}-src.tgz`
1112
- This tarball includes the full ext/ directory from the submodule
1213
- It's uploaded as a GitHub release asset
1314
- PIE automatically detects and uses this pre-packaged source instead of the ZIP archive
1415

1516
This is the same approach used by the MongoDB extension and others with submodule dependencies. See:
1617
- https://github.com/php/pie/issues/39
17-
- MongoDB extension implementation
18+
- MongoDB extension implementation: https://github.com/mongodb/mongo-php-driver
1819

1920
## Phase 1: Create Extension Repository Structure
2021

@@ -50,6 +51,7 @@ Initial files needed:
5051
"priority": 50,
5152
"support-zts": true,
5253
"support-nts": true,
54+
"source-method": "pre-packaged-source",
5355
"build-path": "MaxMind-DB-Reader-php/ext",
5456
"configure-options": [
5557
{

0 commit comments

Comments
 (0)