Skip to content

Commit a20b6dc

Browse files
committed
Appease Rubocop
Fixes: ``` Offenses: lib/maxmind/db.rb:276:27: C: [Correctable] Style/MinMaxComparison: Use [@SiZe, METADATA_MAX_SIZE].min instead. metadata_max_size = @SiZe < METADATA_MAX_SIZE ? @SiZe : METADATA_MAX_SIZE ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ maxmind-db.gemspec:24:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile. s.add_development_dependency 'minitest' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ maxmind-db.gemspec:25:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile. s.add_development_dependency 'rake' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ maxmind-db.gemspec:26:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile. s.add_development_dependency 'rubocop' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ maxmind-db.gemspec:27:3: C: Gemspec/DevelopmentDependencies: Specify development dependencies in Gemfile. s.add_development_dependency 'rubocop-performance' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ```
1 parent f3ee6cb commit a20b6dc

File tree

3 files changed

+6
-1
lines changed

3 files changed

+6
-1
lines changed

.gitignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
11
*.swp
22
/doc
33
/.yardoc
4+
Gemfile.lock
5+

.rubocop.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,3 +27,6 @@ Style/TrailingCommaInArrayLiteral:
2727
Enabled: false
2828
Style/TrailingCommaInHashLiteral:
2929
Enabled: false
30+
31+
Gemspec/DevelopmentDependencies:
32+
Enabled: false

lib/maxmind/db.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ def resolve_data_pointer(pointer)
273273
end
274274

275275
def find_metadata_start
276-
metadata_max_size = @size < METADATA_MAX_SIZE ? @size : METADATA_MAX_SIZE
276+
metadata_max_size = [@size, METADATA_MAX_SIZE].min
277277

278278
stop_index = @size - metadata_max_size
279279
index = @size - METADATA_START_MARKER_LENGTH

0 commit comments

Comments
 (0)