docker image and downloads limit break loop #381
Description
I use docker compose with ansible, and I run with these 2 settings:
geoip:
image: "ghcr.io/maxmind/geoipupdate"
restart: always
volumes:
- geodb:/usr/share/GeoIP
environment:
GEOIPUPDATE_FREQUENCY: 12
Thats 12 hours between updates, and restart the container if it fails
Under normal operation the process: logs show it all seems ok:
# STATE: Sleeping for 12 hours
# STATE: Running geoipupdate
But today, I found the image in a loop:
Error retrieving updates: running the job processor: running job: unexpected HTTP status code: received HTTP status code: 429: {"code":"LIMIT_EXCEEDED","error":"Daily GeoIP database download limit reached"}
# STATE: Running geoipupdate
Error retrieving updates: running the job processor: running job: unexpected HTTP status code: received HTTP status code: 429: {"code":"LIMIT_EXCEEDED","error":"Daily GeoIP database download limit reached"}
# STATE: Running geoipupdate
Error retrieving updates: running the job processor: running job: unexpected HTTP status code: received HTTP status code: 429: {"code":"LIMIT_EXCEEDED","error":"Daily GeoIP database download limit reached"}
# STATE: Running geoipupdate
Error retrieving updates: running the job processor: running job: unexpected HTTP status code: received HTTP status code: 429: {"code":"LIMIT_EXCEEDED","error":"Daily GeoIP database download limit reached"}
# STATE: Running geoipupdate
....
With one request per second....
I guess, the geoipupdate must NOT fail under this condition, simply inform that the update is skipped due to reached limit.
Failing will kill the docker image and triggers a docker restart, that again will result in the same outcome hitting MaxMid servers once per second.
Normally scripts will continue to work even if a command fails, which would be the desired outcome, unless you include the following statement:
That makes the script fail, and triggers the loop.