Remove periods from gmail.com local parts

horgh · horgh · commit 6c43d638dc4c · 2024-01-26T12:08:07.000-08:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,9 @@
 
 * Equivalent domain names are now normalized when `hash_address` is used.
   For example, `googlemail.com` will become `gmail.com`.
+* Periods are now removed from `gmail.com` email address local parts when
+  `hash_address` is used. For example, `f.o.o@gmail.com` will become
+  `foo@gmail.com`.
 
 ## v2.4.0 (2024-01-12)
 
diff --git a/lib/minfraud/components/email.rb b/lib/minfraud/components/email.rb
@@ -96,6 +96,10 @@ def clean_email_address(address)
           local_part.sub!(/\A([^+]+)\+.*\z/, '\1')
         end
 
+        if domain == 'gmail.com'
+          local_part.gsub!('.', '')
+        end
+
         "#{local_part}@#{domain}"
       end
 
diff --git a/spec/components/email_spec.rb b/spec/components/email_spec.rb
@@ -69,9 +69,10 @@
         { input: 'Test-foo@yahoo.com', output: 'test@yahoo.com' },
         { input: 'Test-foo-foo2@yahoo.com', output: 'test@yahoo.com' },
         { input: 'Test-foo@gmail.com', output: 'test-foo@gmail.com' },
-        { input: 'gamil.com@gamil.com', output: 'gamil.com@gmail.com' },
+        { input: 'gamil.com@gamil.com', output: 'gamilcom@gmail.com' },
         { input: 'Test+alias@bücher.com', output: 'test@xn--bcher-kva.com' },
         { input: 'foo@googlemail.com', output: 'foo@gmail.com' },
+        { input: 'foo.bar@gmail.com', output: 'foobar@gmail.com' },
       ]
 
       tests.each do |i|

-Original file line number
+Diff line change
         { input: '[email protected]', output: '[email protected]' },
         { input: '[email protected]', output: '[email protected]' },
         { input: '[email protected]', output: '[email protected]' },
 -        { input: '[email protected]', output: 'gamil.com@gmail.com' },
 +        { input: '[email protected]', output: 'gamilcom@gmail.com' },
         { input: 'Test+alias@bücher.com', output: '[email protected]' },
         { input: '[email protected]', output: '[email protected]' },
 +        { input: '[email protected]', output: '[email protected]' },
+      ]
       tests.each do |i|