Add support for 8 digit IINs and 2 digit last_digits

Previously issuer_id_number was expected to be 6 digits and
last_4_digits to be 4 digits. This changes the validation to
additionally allow for 8 digit issuer_id_numbers and 2 digit
last_4_digits.

Additionally last_4_digits has been deprecated in favor of the
more appropriately named last_digits.

Author: ugexe

README.md

@@ -123,7 +123,7 @@ assessment = Minfraud::Assessments.new(
   },
   credit_card: {
     issuer_id_number:         '411111',
-    last_4_digits:            '7643',
+    last_digits:              '7643',
     bank_name:                'Bank of No Hope',
     bank_phone_country_code:  '1',
     bank_phone_number:        '123-456-1234',

lib/minfraud/components/credit_card.rb

@@ -8,16 +8,27 @@ module Components
     class CreditCard < Base
       include Minfraud::Validates
 
-      # The issuer ID number for the credit card. This is the first 6 digits of
-      # the credit card number. It identifies the issuing bank.
+      # The issuer ID number for the credit card. This is the first 6 or 8
+      # digits of the credit card number. It identifies the issuing bank.
       #
       # @return [String, nil]
       attr_accessor :issuer_id_number
 
-      # The last four digits of the credit card number.
+      # The last digits of the credit card number. This is the last 4
+      # digits if the issuer ID number is 6 digits, or the last 2 digits
+      # if the issuer ID number is 8 digits.
       #
       # @return [String, nil]
-      attr_accessor :last_4_digits
+      attr_accessor :last_digits
+
+      # The last digits of the credit card number. This is the last 4
+      # digits if the issuer ID number is 6 digits, or the last 2 digits
+      # if the issuer ID number is 8 digits.
+      #
+      # @deprecated Use {::last_digits} instead.
+      #
+      # @return [String, nil]
+      alias last_4_digits last_digits
 
       # The name of the issuing bank as provided by the end user.
       #
@@ -77,7 +88,7 @@ class CreditCard < Base
       def initialize(params = {})
         @bank_phone_country_code  = params[:bank_phone_country_code]
         @issuer_id_number         = params[:issuer_id_number]
-        @last_4_digits            = params[:last_4_digits]
+        @last_digits              = params[:last_digits] || params[:last_4_digits]
         @bank_name                = params[:bank_name]
         @bank_phone_number        = params[:bank_phone_number]
         @avs_result               = params[:avs_result]
@@ -94,8 +105,8 @@ def validate
         return if !Minfraud.enable_validation
 
         validate_telephone_country_code('bank_phone_country_code', @bank_phone_country_code)
-        validate_regex('issuer_id_number', /\A[0-9]{6}\z/, @issuer_id_number)
-        validate_regex('last_4_digits', /\A[0-9]{4}\z/, @last_4_digits)
+        validate_regex('issuer_id_number', /\A(?:[0-9]{6}|[0-9]{8})\z/, @issuer_id_number)
+        validate_regex('last_digits', /\A(?:[0-9]{2}|[0-9]{4})\z/, @last_digits)
         validate_string('bank_name', 255, @bank_name)
         validate_string('bank_phone_number', 255, @bank_phone_number)
         validate_string('avs_result', 1, @avs_result)

spec/components/credit_card_spec.rb

@@ -16,10 +16,18 @@
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
+    it 'raises an exception for an invalid last_digits' do
+      expect do
+        Minfraud::Components::CreditCard.new(
+          last_digits: '6',
+        )
+      end.to raise_exception(Minfraud::InvalidInputError)
+    end
+
     it 'raises an exception for an invalid last_4_digits' do
       expect do
         Minfraud::Components::CreditCard.new(
-          last_4_digits: '6',
+          last_digits: '6',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
@@ -40,19 +48,41 @@
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
-    it 'does not raise an exception for valid values' do
-      Minfraud::Components::CreditCard.new(
+    it 'does not raise an exception for valid values (deprecated last_4_digits)' do
+      @cc = Minfraud::Components::CreditCard.new(
         issuer_id_number:         '123456',
         last_4_digits:            '1234',
         token:                    'abcd',
         was_3d_secure_successful: true,
       )
+      expect(@cc.last_digits).to be(@cc.last_4_digits)
+      expect(@cc.last_digits).to be('1234')
+    end
+
+    it 'does not raise an exception for valid values (eight digit issuer_id_number)' do
+      Minfraud::Components::CreditCard.new(
+        issuer_id_number:         '12345678',
+        last_4_digits:            '1234',
+        token:                    'abcd',
+        was_3d_secure_successful: true,
+      )
+    end
+
+    it 'does not raise an exception for valid values (two digit last_digits)' do
+      @cc = Minfraud::Components::CreditCard.new(
+        issuer_id_number:         '12345678',
+        last_digits:              '34',
+        token:                    'abcd',
+        was_3d_secure_successful: true,
+      )
+      expect(@cc.last_digits).to be(@cc.last_4_digits)
+      expect(@cc.last_digits).to be('34')
     end
 
     it 'does not raise an exception for valid values (token is all digits)' do
       Minfraud::Components::CreditCard.new(
         issuer_id_number:         '123456',
-        last_4_digits:            '1234',
+        last_digits:              '1234',
         token:                    '1' * 20,
         was_3d_secure_successful: true,
       )