Enable rubocop-performance plugin

Author: horgh

.rubocop.yml

@@ -1,3 +1,6 @@
+plugins:
+    - rubocop-performance
+
 AllCops:
     TargetRubyVersion: '3.2'
     NewCops: enable

lib/minfraud/components/email.rb

@@ -99,7 +99,7 @@ def clean_email_address(address)
         end
 
         if domain == 'gmail.com'
-          local_part.gsub!('.', '')
+          local_part.delete!('.')
         end
 
         domain_parts = domain.split('.')

lib/minfraud/components/report/transaction.rb

@@ -103,7 +103,7 @@ def validate
         end
 
         def empty_uuid?(value)
-          stripped_value = value.to_s.gsub('-', '')
+          stripped_value = value.to_s.delete('-')
           stripped_value == '0' * 32
         end
       end

lib/minfraud/components/shopping_cart.rb

@@ -17,7 +17,7 @@ class ShoppingCart < Base
       #   to an item's field, or as a Minfraud:::Components::ShoppingCartItem
       #   object.
       def initialize(params = [])
-        @items = params.map(&method(:resolve))
+        @items = params.map { |param| resolve(param) }
       end
 
       # A JSON representation of Minfraud::Components::ShoppingCart items.

lib/minfraud/validates.rb

@@ -27,7 +27,7 @@ def validate_md5(field, value)
     def validate_uuid(field, value)
       return if !value
 
-      stripped_value = value.to_s.gsub('-', '')
+      stripped_value = value.to_s.delete('-')
 
       # Define a regex pattern for a valid UUID without dashes
       uuid_regex = /\A[0-9a-f]{32}\z/i
@@ -78,7 +78,7 @@ def validate_credit_card_token(field, value)
         raise InvalidInputError, "The #{field} value is not valid. It must contain only non-space printable ASCII characters."
       end
 
-      if /\A[0-9]{1,19}\z/.match(s)
+      if /\A[0-9]{1,19}\z/.match?(s)
         raise InvalidInputError, "The #{field} value is not valid. If it is all digits, it must be longer than 19 characters."
       end
     end
@@ -147,7 +147,7 @@ def validate_nonnegative_integer(field, value)
     def validate_email(field, value)
       return if !value
 
-      if /.@./.match(value)
+      if /.@./.match?(value)
         validate_string(field, 255, value)
         return
       end

minfraud.gemspec

@@ -31,6 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rubocop', '~> 1.23'
+  spec.add_development_dependency 'rubocop-performance'
   spec.add_development_dependency 'webmock', '~> 3.14'
   spec.metadata = {
     'rubygems_mfa_required' => 'true'