Skip to content

Commit bda55ff

Browse files
authored
Merge pull request #178 from maxmind/greg/eng-1733
Improve release script reliability (ENG-1733)
2 parents 799cf66 + 2424b0a commit bda55ff

File tree

1 file changed

+36
-5
lines changed

1 file changed

+36
-5
lines changed

dev-bin/release.sh

Lines changed: 36 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,37 @@
22

33
set -eu -o pipefail
44

5+
# Pre-flight checks - verify all required tools are available and configured
6+
# before making any changes to the repository
7+
8+
check_command() {
9+
if ! command -v "$1" &>/dev/null; then
10+
echo "Error: $1 is not installed or not in PATH"
11+
exit 1
12+
fi
13+
}
14+
15+
# Verify gh CLI is authenticated
16+
if ! gh auth status &>/dev/null; then
17+
echo "Error: gh CLI is not authenticated. Run 'gh auth login' first."
18+
exit 1
19+
fi
20+
21+
# Verify we can access this repository via gh
22+
if ! gh repo view --json name &>/dev/null; then
23+
echo "Error: Cannot access repository via gh. Check your authentication and repository access."
24+
exit 1
25+
fi
26+
27+
# Verify git can connect to the remote (catches SSH key issues, etc.)
28+
if ! git ls-remote origin &>/dev/null; then
29+
echo "Error: Cannot connect to git remote. Check your git credentials/SSH keys."
30+
exit 1
31+
fi
32+
33+
check_command perl
34+
check_command rake
35+
536
# Check that we're not on the main branch
637
current_branch=$(git branch --show-current)
738
if [ "$current_branch" = "main" ]; then
@@ -23,20 +54,20 @@ fi
2354
changelog=$(cat CHANGELOG.md)
2455

2556
regex='
26-
## v([0-9]+\.[0-9]+\.[0-9]+(.[a-z0-9]+)?) \(([0-9]{4}-[0-9]{2}-[0-9]{2})\)
57+
## v([0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?) \(([0-9]{4}-[0-9]{2}-[0-9]{2})\)
2758
2859
((.|
2960
)*)
3061
'
3162

3263
if [[ ! $changelog =~ $regex ]]; then
33-
echo "Could not find date line in change log!"
34-
exit 1
64+
echo "Could not find date line in change log!"
65+
exit 1
3566
fi
3667

3768
version="${BASH_REMATCH[1]}"
3869
date="${BASH_REMATCH[3]}"
39-
notes="$(echo "${BASH_REMATCH[4]}" | sed -n -E '/^## v[0-9]+\.[0-9]+\.[0-9]+/,$!p')"
70+
notes="$(echo "${BASH_REMATCH[4]}" | sed -n -E '/^## v[0-9]+\.[0-9]+\.[0-9]+(-[a-zA-Z0-9.]+)?/,$!p')"
4071

4172
echo "$notes"
4273
if [[ "$date" != "$(date +"%Y-%m-%d")" ]]; then
@@ -63,7 +94,7 @@ git diff
6394
echo $'\nRelease notes:'
6495
echo "$notes"
6596

66-
read -e -p "Commit changes and push to origin? " should_push
97+
read -r -e -p "Commit changes and push to origin? " should_push
6798

6899
if [ "$should_push" != "y" ]; then
69100
echo "Aborting"

0 commit comments

Comments
 (0)