Enable rubocop-rspec plugin

Author: horgh

.rubocop.yml

@@ -1,6 +1,7 @@
 plugins:
     - rubocop-performance
     - rubocop-rake
+    - rubocop-rspec
 
 AllCops:
     TargetRubyVersion: '3.2'
@@ -92,3 +93,20 @@ Naming/VariableNumber:
 
 Gemspec/DevelopmentDependencies:
   Enabled: false
+
+# This might make sense, but I don't think it's worth moving things around for.
+RSpec/SpecFilePathFormat:
+  Enabled: false
+# Sometimes it makes sense to have lots of assertions.
+RSpec/MultipleExpectations:
+  Enabled: false
+# Sometimes it makes sense to have long tests.
+RSpec/ExampleLength:
+  Enabled: false
+# This seems okay.
+RSpec/MultipleDescribes:
+  Enabled: false
+# This seems to give a bunch of false positives. Specifically it's flagging
+# things where we are creating an object and checking no exception happens.
+RSpec/NoExpectationExample:
+  Enabled: false

minfraud.gemspec

@@ -33,6 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'rubocop', '~> 1.23'
   spec.add_development_dependency 'rubocop-performance'
   spec.add_development_dependency 'rubocop-rake'
+  spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'webmock', '~> 3.14'
   spec.metadata = {
     'rubygems_mfa_required' => 'true'

spec/assessments_spec.rb

@@ -3,22 +3,23 @@
 require 'spec_helper'
 
 describe Minfraud::Assessments do
-  let(:resolver)      { double(Minfraud::Resolver) }
-  subject             { described_class.new({}, resolver) }
+  subject(:assessment) { described_class.new({}, resolver) }
+
+  let(:resolver)       { class_double(Minfraud::Resolver) }
 
   before { allow(resolver).to receive(:assign) }
 
   %w[account billing credit_card custom_inputs device email event order payment shipping shopping_cart].each do |attribute|
     it "responds_to #{attribute}" do
-      expect(subject).to respond_to(attribute)
+      expect(assessment).to respond_to(attribute)
     end
   end
 
   describe '#initialize' do
     it { is_expected.to be_an_instance_of described_class }
 
     it 'calls resolver for components assignment' do
-      expect(resolver).to have_received(:assign).with(subject, {})
+      expect(resolver).to have_received(:assign).with(assessment, {})
     end
   end
 
@@ -63,7 +64,7 @@
       ]
 
       tests.each do |i|
-        assessment = Minfraud::Assessments.new(
+        assessment = described_class.new(
           email: i[:email],
         )
         body       = assessment.send :request_body

spec/components/account_spec.rb

@@ -10,26 +10,26 @@
 
     it 'raises an exception for an invalid user_id' do
       expect do
-        Minfraud::Components::Account.new(
+        described_class.new(
           user_id: 'x' * 256,
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid username_md5' do
       expect do
-        Minfraud::Components::Account.new(
+        described_class.new(
           username_md5: 'd3b07384d113edec49eaa6238ad5ff0Z',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'does not raise an exception if fields are not populated' do
-      Minfraud::Components::Account.new
+      described_class.new
     end
 
     it 'does not raise an exception for valid values' do
-      Minfraud::Components::Account.new(
+      described_class.new(
         user_id:      10,
         username_md5: 'd3b07384d113edec49eaa6238ad5ff00',
       )

spec/components/base_spec.rb

@@ -3,28 +3,31 @@
 require 'spec_helper'
 
 describe Minfraud::Components::Base do
+  subject(:base_component) { described_class.new }
+
   describe '#to_json' do
     it 'has to be an instance of Hash' do
-      expect(subject.to_json).to be_an_instance_of Hash
+      expect(base_component.to_json).to be_an_instance_of Hash
     end
 
     context 'with no instance variables' do
       it 'has to be empty' do
-        expect(subject.to_json).to be_empty
+        expect(base_component.to_json).to be_empty
       end
     end
 
     context 'with instance variables' do
       let(:expected) { { 'dummy' => 'test@example' } }
-      before(:each)  { subject.instance_variable_set(:@dummy, 'test@example') }
+
+      before { base_component.instance_variable_set(:@dummy, 'test@example') }
 
       it 'returns json representation of attributes' do
-        expect(subject.to_json).to eq(expected)
+        expect(base_component.to_json).to eq(expected)
       end
 
       it 'returns json while ignoring nil values' do
-        subject.instance_variable_set(:@null, nil)
-        expect(subject.to_json).to eq(expected)
+        base_component.instance_variable_set(:@null, nil)
+        expect(base_component.to_json).to eq(expected)
       end
     end
   end

spec/components/billing_spec.rb

@@ -10,30 +10,30 @@
 
     it 'raises an exception for an invalid region' do
       expect do
-        Minfraud::Components::Billing.new(
+        described_class.new(
           region: 'HIHIHI',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid country' do
       expect do
-        Minfraud::Components::Billing.new(
+        described_class.new(
           country: 'HIHIHI',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid phone_country_code' do
       expect do
-        Minfraud::Components::Billing.new(
+        described_class.new(
           phone_country_code: 'HIHIHI',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'does not raise an exception for valid values' do
-      Minfraud::Components::Billing.new(
+      described_class.new(
         region:             'BC',
         country:            'CA',
         phone_country_code: '1',

spec/components/credit_card_spec.rb

@@ -10,57 +10,57 @@
 
     it 'raises an exception for an invalid issuer_id_number' do
       expect do
-        Minfraud::Components::CreditCard.new(
+        described_class.new(
           issuer_id_number: '5',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid last_digits' do
       expect do
-        Minfraud::Components::CreditCard.new(
+        described_class.new(
           last_digits: '6',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid last_4_digits' do
       expect do
-        Minfraud::Components::CreditCard.new(
+        described_class.new(
           last_4_digits: '6',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid token' do
       expect do
-        Minfraud::Components::CreditCard.new(
+        described_class.new(
           token: '☃️',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid token (all digits)' do
       expect do
-        Minfraud::Components::CreditCard.new(
+        described_class.new(
           token: '123',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'does not raise an exception for valid values (deprecated last_4_digits)' do
-      @cc = Minfraud::Components::CreditCard.new(
+      cc = described_class.new(
         issuer_id_number:         '123456',
         last_4_digits:            '1234',
         token:                    'abcd',
         was_3d_secure_successful: true,
       )
-      expect(@cc.last_digits).to be(@cc.last_4_digits)
-      expect(@cc.last_digits).to be('1234')
+      expect(cc.last_digits).to be(cc.last_4_digits)
+      expect(cc.last_digits).to be('1234')
     end
 
     it 'does not raise an exception for valid values (eight digit issuer_id_number)' do
-      Minfraud::Components::CreditCard.new(
+      described_class.new(
         issuer_id_number:         '12345678',
         last_4_digits:            '1234',
         token:                    'abcd',
@@ -69,18 +69,18 @@
     end
 
     it 'does not raise an exception for valid values (two digit last_digits)' do
-      @cc = Minfraud::Components::CreditCard.new(
+      cc = described_class.new(
         issuer_id_number:         '12345678',
         last_digits:              '34',
         token:                    'abcd',
         was_3d_secure_successful: true,
       )
-      expect(@cc.last_digits).to be(@cc.last_4_digits)
-      expect(@cc.last_digits).to be('34')
+      expect(cc.last_digits).to be(cc.last_4_digits)
+      expect(cc.last_digits).to be('34')
     end
 
     it 'does not raise an exception for valid values (token is all digits)' do
-      Minfraud::Components::CreditCard.new(
+      described_class.new(
         issuer_id_number:         '123456',
         last_digits:              '1234',
         token:                    '1' * 20,
@@ -89,7 +89,7 @@
     end
 
     it 'does not raise an exception when country is given and issuer_id_number is not provided' do
-      Minfraud::Components::CreditCard.new(
+      described_class.new(
         country: 'CA',
       )
     end

spec/components/custom_inputs_spec.rb

@@ -3,12 +3,13 @@
 require 'spec_helper'
 
 describe Minfraud::Components::CustomInputs do
+  subject(:custom_inputs) { described_class.new(params) }
+
   let(:params) { { some_key: 'some value' } }
-  subject { described_class.new(params) }
 
   describe '#initialize' do
     it 'sets the params as instance variables' do
-      expect(subject.instance_variable_get(:@some_key)).to eql(params[:some_key])
+      expect(custom_inputs.instance_variable_get(:@some_key)).to eql(params[:some_key])
     end
   end
 
@@ -19,30 +20,30 @@
 
     it 'raises an exception for an invalid number' do
       expect do
-        Minfraud::Components::CustomInputs.new(
+        described_class.new(
           number: 1e13,
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid number (negative)' do
       expect do
-        Minfraud::Components::CustomInputs.new(
+        described_class.new(
           number: -1e13,
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid string' do
       expect do
-        Minfraud::Components::CustomInputs.new(
+        described_class.new(
           string: 'f' * 257,
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'does not raise an exception for valid values' do
-      Minfraud::Components::CustomInputs.new(
+      described_class.new(
         number: 10,
         string: 'foo',
       )

spec/components/device_spec.rb

@@ -10,52 +10,52 @@
 
     it 'raises an exception for an invalid IP' do
       expect do
-        Minfraud::Components::Device.new(
+        described_class.new(
           ip_address: 'foo',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid IP (a network)' do
       expect do
-        Minfraud::Components::Device.new(
+        described_class.new(
           ip_address: '1.2.3.4/24',
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid session age' do
       expect do
-        Minfraud::Components::Device.new(
+        described_class.new(
           session_age: -1,
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'raises an exception for an invalid session age (too big)' do
       expect do
-        Minfraud::Components::Device.new(
+        described_class.new(
           session_age: 1e13,
         )
       end.to raise_exception(Minfraud::InvalidInputError)
     end
 
     it 'does not raise an exception for valid values' do
-      Minfraud::Components::Device.new(
+      described_class.new(
         ip_address:  '1.2.3.4',
         session_age: 10,
       )
     end
 
     it 'does not raise an exception for valid values (IPv6)' do
-      Minfraud::Components::Device.new(
+      described_class.new(
         ip_address:  'dead::ffff',
         session_age: 100,
       )
     end
 
     it 'does not raise an exception if no IP is provided' do
-      Minfraud::Components::Device.new(
+      described_class.new(
         session_age: 100,
       )
     end