Merge pull request #95 from maxmind/horgh/period

ugexe · web-flow · commit ea95d39e92c0 · 2024-03-20T12:00:01.000-05:00
Remove all trailing periods from domains
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -24,6 +24,8 @@
   become `gmail.com`.
 * Additional `gmail.com` typos are now normalized when `hash_address` is
   used. For example, `gmali.com` will become `gmail.com`.
+* When `hash_address` is used, all trailing periods are now removed from an
+  email address domain. Previously only a single period was removed.
 
 ## v2.4.0 (2024-01-12)
 
diff --git a/lib/minfraud/components/email.rb b/lib/minfraud/components/email.rb
@@ -373,8 +373,7 @@ def clean_email_address(address)
       def clean_domain(domain)
         domain = domain.strip
 
-        # We could use delete_suffix!, but that is in Ruby 2.5+ only.
-        domain.sub!(/\.\z/, '')
+        domain.sub!(/\.+\z/, '')
 
         domain = SimpleIDN.to_ascii(domain)
 
diff --git a/spec/components/email_spec.rb b/spec/components/email_spec.rb
@@ -80,6 +80,8 @@
         { input: 'foo@example.cam', output: 'foo@example.cam' },
         { input: 'foo@10000gmail.com', output: 'foo@gmail.com' },
         { input: 'foo@example.comcom', output: 'foo@example.com' },
+        { input: 'foo@example.com.', output: 'foo@example.com' },
+        { input: 'foo@example.com...', output: 'foo@example.com' },
       ]
 
       tests.each do |i|

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,8 @@`
`80`	`80`	`{ input: '[email protected]', output: '[email protected]' },`
`81`	`81`	`{ input: '[email protected]', output: '[email protected]' },`
`82`	`82`	`{ input: '[email protected]', output: '[email protected]' },`
	`83`	`+ { input: '[email protected].', output: '[email protected]' },`
	`84`	`+ { input: '[email protected]...', output: '[email protected]' },`
`83`	`85`	`]`
`84`	`86`
`85`	`87`	`tests.each do \|i\|`