Apply suggestions from code review

Co-authored-by: Davis Bennett <[email protected]>

Author: maxrjones

src/zarr/storage/_fsspec.py

@@ -255,7 +255,7 @@ async def set(
             await self._open()
         self._check_writable()
         if not isinstance(value, Buffer):
-            raise TypeError("FsspecStore.set(): `value` must a Buffer instance")
+            raise TypeError(f"FsspecStore.set(): `value` must a Buffer instance. Got an instance of {type(value)} instead.")
         path = _dereference_path(self.path, key)
         # write data
         if byte_range:

src/zarr/testing/store.py

@@ -262,7 +262,7 @@ async def test_set_many(self, store: S) -> None:
         for k, v in store_dict.items():
             assert (await self.get(store, k)).to_bytes() == v.to_bytes()
 
-    async def test_set_raises(self, store: S) -> None:
+    async def test_set_invalid_buffer(self, store: S) -> None:
         """
         Ensure that set raises a Type or Value Error for invalid buffer arguments.
         """

tests/test_store/test_core.py

@@ -15,7 +15,7 @@
 @pytest.mark.parametrize("zarr_format", [2, 3])
 async def test_contains_group(local_store, write_group: bool, zarr_format: ZarrFormat) -> None:
     """
-    Test contains group method
+     Test that the contains_group method correctly reports the existence of a group.
     """
     root = Group.from_store(store=local_store, zarr_format=zarr_format)
     if write_group:
@@ -28,7 +28,7 @@ async def test_contains_group(local_store, write_group: bool, zarr_format: ZarrF
 @pytest.mark.parametrize("zarr_format", [2, 3])
 async def test_contains_array(local_store, write_array: bool, zarr_format: ZarrFormat) -> None:
     """
-    Test contains group method
+    Test that the contains array method correctly reports the existence of an array.
     """
     root = Group.from_store(store=local_store, zarr_format=zarr_format)
     if write_array:

tests/test_store/test_local.py

@@ -61,7 +61,7 @@ def test_invalid_root_raises(self):
 
     async def test_get_with_prototype_default(self, store: LocalStore):
         """
-        Ensure that data can be read using the default prototype method.
+        Ensure that data can be read via ``store.get`` if the prototype keyword argument is unspecified, i.e. set to ``None``.
         """
         data_buf = self.buffer_cls.from_bytes(b"\x01\x02\x03\x04")
         key = "c/0"