Don't implement _is_open setter on wrapped stores

Author: maxrjones

src/zarr/storage/_logging.py

@@ -137,8 +137,7 @@ def _is_open(self) -> bool:
 
     @_is_open.setter
     def _is_open(self, value: bool) -> None:
-        with self.log(value):
-            self._store._is_open = value
+        raise NotImplementedError("LoggingStore must be opened via the `_open` method")
 
     async def _open(self) -> None:
         with self.log():

src/zarr/storage/_wrapper.py

@@ -62,7 +62,7 @@ def _is_open(self) -> bool:
 
     @_is_open.setter
     def _is_open(self, value: bool) -> None:
-        self._store._is_open = value
+        raise NotImplementedError("WrapperStore must be opened via the `_open` method")
 
     async def clear(self) -> None:
         return await self._store.clear()

tests/test_store/test_logging.py

@@ -71,6 +71,13 @@ async def test_default_handler(self, local_store, capsys) -> None:
         for h in handlers:
             logging.getLogger().addHandler(h)
 
+    def test_is_open_setter_raises(self, store: LoggingStore) -> None:
+        "Test that a user cannot change `_is_open` without opening the underlying store."
+        with pytest.raises(
+            NotImplementedError, match="LoggingStore must be opened via the `_open` method"
+        ):
+            store._is_open = True
+
 
 @pytest.mark.parametrize("store", ["local", "memory", "zip"], indirect=["store"])
 async def test_logging_store(store: Store, caplog) -> None:

tests/test_store/test_wrapper.py

@@ -52,6 +52,13 @@ def test_store_supports_listing(self, store: WrapperStore) -> None:
     def test_store_repr(self, store: WrapperStore) -> None:
         assert str(store) == f"wrapping-file://{store._store.root.as_posix()}"
 
+    def test_is_open_setter_raises(self, store: WrapperStore) -> None:
+        "Test that a user cannot change `_is_open` without opening the underlying store."
+        with pytest.raises(
+            NotImplementedError, match="WrapperStore must be opened via the `_open` method"
+        ):
+            store._is_open = True
+
 
 @pytest.mark.parametrize("store", ["local", "memory", "zip"], indirect=True)
 async def test_wrapped_set(store: Store, capsys: pytest.CaptureFixture[str]) -> None: