Apply RuboCop linting fixes

Shpigford · claude · Shpigford · commit a19fe4577e7b · 2025-07-14T15:29:16.000-05:00
- Fixed spacing inside array brackets - Converted old hash syntax to new Ruby 1.9 syntax - Removed trailing whitespace - Fixed string quote consistency - Added missing final newlines - Applied all RuboCop auto-corrections 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
diff --git a/app/avo/resources/article.rb b/app/avo/resources/article.rb
@@ -14,8 +14,8 @@ def fields
     field :slug, as: :text
     field :content, as: :easy_mde
     field :publish_at, as: :date_time
-    field :author_name, as: :text, hide_on: [:forms]
-    
+    field :author_name, as: :text, hide_on: [ :forms ]
+
     tabs do
       tab "Author" do
         field :authorship, as: :has_one
diff --git a/app/avo/resources/author.rb b/app/avo/resources/author.rb
@@ -16,8 +16,8 @@ def fields
     field :avatar_url, as: :text
     field :position, as: :text
     field :email, as: :text
-    field :social_links, as: :code, language: 'javascript'
-    
+    field :social_links, as: :code, language: "javascript"
+
     tabs do
       tab "Content" do
         field :articles, as: :has_many
@@ -26,4 +26,4 @@ def fields
       end
     end
   end
-end
+end
diff --git a/app/avo/resources/authorship.rb b/app/avo/resources/authorship.rb
@@ -1,17 +1,17 @@
 class Avo::Resources::Authorship < Avo::BaseResource
-  self.includes = [:author, :authorable]
-  
+  self.includes = [ :author, :authorable ]
+
   def fields
     field :id, as: :id
     field :author, as: :belongs_to, searchable: true
-    field :authorable, as: :belongs_to, polymorphic_as: :authorable, 
-      types: [::Article, ::Term, ::Faq]
+    field :authorable, as: :belongs_to, polymorphic_as: :authorable,
+      types: [ ::Article, ::Term, ::Faq ]
     field :role, as: :select, options: {
       primary: "Primary",
-      contributor: "Contributor", 
+      contributor: "Contributor",
       editor: "Editor",
       reviewer: "Reviewer"
     }, default: "primary"
     field :position, as: :number, default: 0
   end
-end
+end
diff --git a/app/avo/resources/faq.rb b/app/avo/resources/faq.rb
@@ -14,7 +14,7 @@ def fields
     field :answer, as: :easy_mde
     field :slug, as: :text
     field :category, as: :select, options: Faq::CATEGORIES
-    
+
     tabs do
       tab "Author" do
         field :authorship, as: :has_one
diff --git a/app/avo/resources/term.rb b/app/avo/resources/term.rb
@@ -18,7 +18,7 @@ def fields
     field :video_description, as: :textarea
     field :video_upload_date, as: :date
     field :video_duration, as: :text
-    
+
     tabs do
       tab "Author" do
         field :authorship, as: :has_one
diff --git a/app/controllers/articles_controller.rb b/app/controllers/articles_controller.rb
@@ -10,12 +10,12 @@ class ArticlesController < ApplicationController
   # @example
   #   GET /articles
   def index
-    @featured_article = Article.published.latest.includes(:authorship => :author).first
+    @featured_article = Article.published.latest.includes(authorship: :author).first
     @pagy, @articles = pagy(
       Article.published
             .where.not(id: @featured_article&.id)
             .latest
-            .includes(:authorship => :author),
+            .includes(authorship: :author),
       items: 6,
       limit: 6
     )
@@ -29,7 +29,7 @@ def index
   # @example
   #   GET /articles/my-first-article
   def show
-    @article = Article.includes(:authorship => :author).find_by(slug: params[:id])
+    @article = Article.includes(authorship: :author).find_by(slug: params[:id])
     redirect_to articles_path unless @article
   end
 end
diff --git a/app/controllers/authors_controller.rb b/app/controllers/authors_controller.rb
@@ -1,21 +1,21 @@
 class AuthorsController < ApplicationController
-  before_action :set_author, only: [:show]
-  
+  before_action :set_author, only: [ :show ]
+
   def index
     @authors = Author.includes(:authorships).order(:name)
   end
-  
+
   def show
-    @articles = @author.articles.published.latest.includes(:authorship => :author)
-    @terms = @author.terms.includes(:authorship => :author)
-    @faqs = @author.faqs.includes(:authorship => :author)
-    
+    @articles = @author.articles.published.latest.includes(authorship: :author)
+    @terms = @author.terms.includes(authorship: :author)
+    @faqs = @author.faqs.includes(authorship: :author)
+
     @content_count = @articles.count + @terms.count + @faqs.count
   end
-  
+
   private
-  
+
   def set_author
     @author = Author.find_by!(slug: params[:slug])
   end
-end
+end
diff --git a/app/controllers/avo/authors_controller.rb b/app/controllers/avo/authors_controller.rb
@@ -1,2 +1,2 @@
 class Avo::AuthorsController < Avo::ResourcesController
-end
+end
diff --git a/app/controllers/avo/authorships_controller.rb b/app/controllers/avo/authorships_controller.rb
@@ -1,2 +1,2 @@
 class Avo::AuthorshipsController < Avo::ResourcesController
-end
+end
diff --git a/app/controllers/faqs_controller.rb b/app/controllers/faqs_controller.rb
@@ -41,7 +41,7 @@ def index
   # @example
   #   GET /faqs/what-is-compound-interest
   def show
-    @faq = Faq.includes(:authorship => :author).find_by(slug: params[:id])
+    @faq = Faq.includes(authorship: :author).find_by(slug: params[:id])
 
     unless @faq
       redirect_to faqs_path, alert: "FAQ not found"
diff --git a/app/controllers/terms_controller.rb b/app/controllers/terms_controller.rb
@@ -26,7 +26,7 @@ def index
   # @example
   #   GET /terms/ruby-on-rails
   def show
-    @term = Term.includes(:authorship => :author).find_by(slug: params[:id])
+    @term = Term.includes(authorship: :author).find_by(slug: params[:id])
 
     if @term.nil?
       redirect_to terms_path, alert: "The financial term you're looking for could not be found."
diff --git a/app/models/article.rb b/app/models/article.rb
@@ -16,7 +16,7 @@
 class Article < ApplicationRecord
   has_one :authorship, as: :authorable, dependent: :destroy
   has_one :author, through: :authorship
-  
+
   scope :published, -> { where.not(publish_at: nil).where("publish_at <= ?", Time.current) }
   scope :latest, -> { order(publish_at: :desc) }
 
diff --git a/app/models/author.rb b/app/models/author.rb
@@ -3,19 +3,19 @@ class Author < ApplicationRecord
   has_many :articles, through: :authorships, source: :authorable, source_type: "Article"
   has_many :terms, through: :authorships, source: :authorable, source_type: "Term"
   has_many :faqs, through: :authorships, source: :authorable, source_type: "Faq"
-  
+
   validates :name, presence: true
   validates :slug, presence: true, uniqueness: true
-  
+
   before_validation :generate_slug, if: -> { slug.blank? }
-  
+
   def to_param
     slug
   end
-  
+
   private
-  
+
   def generate_slug
     self.slug = name.parameterize if name.present?
   end
-end
+end
diff --git a/app/models/authorship.rb b/app/models/authorship.rb
@@ -1,12 +1,12 @@
 class Authorship < ApplicationRecord
   belongs_to :author
   belongs_to :authorable, polymorphic: true
-  
+
   validates :author, presence: true
   validates :authorable, presence: true
   validates :role, inclusion: { in: %w[primary contributor editor reviewer], allow_blank: true }
-  
+
   scope :ordered, -> { order(:position) }
   scope :primary, -> { where(role: "primary") }
   scope :contributors, -> { where(role: "contributor") }
-end
+end
diff --git a/app/models/faq.rb b/app/models/faq.rb
@@ -20,7 +20,7 @@
 class Faq < ApplicationRecord
   has_one :authorship, as: :authorable, dependent: :destroy
   has_one :author, through: :authorship
-  
+
   include MetaImage
 
   # Constants for category options
diff --git a/app/models/term.rb b/app/models/term.rb
@@ -21,7 +21,7 @@
 class Term < ApplicationRecord
   has_one :authorship, as: :authorable, dependent: :destroy
   has_one :author, through: :authorship
-  
+
   include MetaImage
 
   def self.random_sample(count, exclude:)
diff --git a/db/migrate/20250714193904_create_authorships.rb b/db/migrate/20250714193904_create_authorships.rb
@@ -8,9 +8,9 @@ def change
 
       t.timestamps
     end
-    
-    add_index :authorships, [:authorable_type, :authorable_id]
-    add_index :authorships, [:author_id, :authorable_type]
+
+    add_index :authorships, [ :authorable_type, :authorable_id ]
+    add_index :authorships, [ :author_id, :authorable_type ]
     add_index :authorships, :position
   end
 end
diff --git a/lib/tasks/migrate_authors.rake b/lib/tasks/migrate_authors.rake
@@ -2,20 +2,20 @@ namespace :data do
   desc "Migrate existing author_name to Author records"
   task migrate_authors: :environment do
     puts "Starting author migration..."
-    
+
     # Get unique author names from articles
-    author_names = Article.where.not(author_name: [nil, ""]).pluck(:author_name).uniq
-    
+    author_names = Article.where.not(author_name: [ nil, "" ]).pluck(:author_name).uniq
+
     author_names.each do |author_name|
       # Find or create the author
       author = Author.find_or_create_by(name: author_name) do |a|
         a.slug = author_name.parameterize
         puts "Creating author: #{author_name}"
       end
-      
+
       # Find all articles by this author
       articles = Article.where(author_name: author_name)
-      
+
       articles.each do |article|
         # Create authorship if it doesn't exist
         unless article.authorship
@@ -28,9 +28,9 @@ namespace :data do
         end
       end
     end
-    
+
     puts "Author migration completed!"
     puts "Total authors created: #{Author.count}"
     puts "Total authorships created: #{Authorship.count}"
   end
-end
+end

Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`class Avo::AuthorsController < Avo::ResourcesController`
`2`		`-end`
	`2`	`+end`
Original file line number	Diff line number	Diff line change
`@@ -1,2 +1,2 @@`
`1`	`1`	`class Avo::AuthorshipsController < Avo::ResourcesController`
`2`		`-end`
	`2`	`+end`