Skip to content

Commit 4698379

Browse files
committed
Do not initialize sidebar multiple times
1 parent ad01652 commit 4698379

File tree

9 files changed

+83
-78
lines changed

9 files changed

+83
-78
lines changed

assets/css/sidebar.css

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -109,25 +109,25 @@
109109
display: none;
110110
}
111111

112-
.sidebar .sidebar-listNav {
112+
.sidebar .sidebar-list-nav {
113113
display: flex;
114114
margin: 0;
115115
padding: 4px 4px 0 4px;
116116
}
117117

118-
.sidebar .sidebar-listNav :is(li, li button) {
118+
.sidebar .sidebar-list-nav :is(li, li button) {
119119
text-transform: uppercase;
120120
letter-spacing: 0.02em;
121121
font-size: 14px;
122122
color: var(--sidebarMuted);
123123
}
124124

125-
.sidebar .sidebar-listNav li {
125+
.sidebar .sidebar-list-nav li {
126126
display: inline-block;
127127
padding: 0;
128128
}
129129

130-
.sidebar .sidebar-listNav li button {
130+
.sidebar .sidebar-list-nav li button {
131131
background: none;
132132
border: 0;
133133
border-radius: 0;
@@ -142,16 +142,16 @@
142142
transition: all 150ms;
143143
}
144144

145-
.sidebar .sidebar-listNav li:is(.selected) button {
145+
.sidebar .sidebar-list-nav li:is(.selected) button {
146146
background-color: var(--sidebarBackground);
147147
border-top: var(--navTabBorderWidth) solid var(--sidebarLanguageAccentBar);
148148
}
149149

150-
.sidebar .sidebar-listNav li:not(.selected) button {
150+
.sidebar .sidebar-list-nav li:not(.selected) button {
151151
border-top: var(--navTabBorderWidth) solid var(--sidebarHeader);
152152
}
153153

154-
.sidebar .sidebar-listNav li:is(:hover):not(.selected) button {
154+
.sidebar .sidebar-list-nav li:is(:hover):not(.selected) button {
155155
background-color: var(--sidebarInactiveItemMarker);
156156
border-top: var(--navTabBorderWidth) solid var(--sidebarInactiveItemBorder);
157157
color: var(--sidebarAccentMain);

assets/js/sidebar/sidebar-list.js

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,9 @@ const SIDEBAR_TYPE = {
88
tasks: 'tasks'
99
}
1010

11-
const SIDEBAR_TAB_TYPES = [SIDEBAR_TYPE.extras, SIDEBAR_TYPE.modules, SIDEBAR_TYPE.tasks]
11+
let sidebarInitialized = false
1212

13+
const SIDEBAR_TAB_TYPES = [SIDEBAR_TYPE.extras, SIDEBAR_TYPE.modules, SIDEBAR_TYPE.tasks]
1314
const sidebarNodeListSelector = type => `#${type}-full-list`
1415

1516
/**
@@ -19,9 +20,13 @@ export function initialize () {
1920
SIDEBAR_TAB_TYPES.forEach(type => {
2021
renderSidebarNodeList(getSidebarNodes(), type)
2122
})
23+
2224
markActiveSidebarTab(getCurrentPageSidebarType())
2325
markCurrentHashInSidebar()
2426
scrollNodeListToCurrentCategory()
27+
28+
if (sidebarInitialized) return
29+
sidebarInitialized = true
2530
addEventListeners()
2631
}
2732

@@ -191,7 +196,7 @@ function addEventListeners () {
191196
})
192197

193198
// provide left/right arrow navigation for tablist, as required by ARIA authoring practices guide
194-
const tabList = qs('#sidebar-listNav')
199+
const tabList = qs('#sidebar-list-nav')
195200
tabList.addEventListener('keydown', (e) => {
196201
if (e.key !== 'ArrowRight' && e.key !== 'ArrowLeft') { return }
197202

formatters/html/dist/html-MQUHN72N.js

Lines changed: 0 additions & 56 deletions
This file was deleted.

formatters/html/dist/html-XFWJYN4N.js

Lines changed: 56 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

formatters/html/dist/html-elixir-4VTRB5LF.css

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

formatters/html/dist/html-elixir-BZS65SHR.css

Lines changed: 0 additions & 6 deletions
This file was deleted.

formatters/html/dist/html-erlang-NQ64IBM7.css

Lines changed: 0 additions & 6 deletions
This file was deleted.

formatters/html/dist/html-erlang-XHVETOWJ.css

Lines changed: 6 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/ex_doc/formatter/html/templates/sidebar_template.eex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</div>
2323
</div>
2424
</div>
25-
<ul id="sidebar-listNav" class="sidebar-listNav" role="tablist">
25+
<ul id="sidebar-list-nav" class="sidebar-list-nav" role="tablist">
2626
<li>
2727
<button id="extras-list-tab-button" role="tab" data-type="extras" aria-controls="extras-tab-panel" aria-selected="true" tabindex="0">
2828
<%= config.extra_section || "Pages" %>

0 commit comments

Comments
 (0)