👌 [#235] fix: Process PR feedback

Author: SilviaAmAm

frontend/src/pages/informatieobjecttype/InformatieObjectType.tsx

@@ -17,7 +17,7 @@ import { useBreadcrumbItems, useCombinedSearchParams } from "~/hooks";
 import { useSubmitAction } from "~/hooks/useSubmitAction";
 import { convertFieldsetsToTabConfig } from "~/lib";
 
-import { AttributeGridSection, TabConfig } from "../zaaktype";
+import { TabConfig } from "../zaaktype";
 import {
   BackendIOT,
   InformatieObjectTypeAction,
@@ -61,11 +61,10 @@ export function InformatieObjectTypePage() {
   }, [newIOTData]);
 
   const onValidate = useCallback<FormValidator>((values: object) => {
-    const errors = {};
     // This is a hack, we are using the validate method to update
     // the state of the informatieobjecttype used in the form
     setNewIOTData(values as PatchedBackendIOT);
-    return errors;
+    return {};
   }, []);
 
   const getButtons = useCallback(
@@ -116,10 +115,12 @@ export function InformatieObjectTypePage() {
 
   // We know that the IOT does not have expansions,
   // so we can narrow the type further
-  const section = fieldSetConfigs[0]
-    .sections[0] as AttributeGridSection<PatchedBackendIOT>;
+  if (fieldSetConfigs[0].view !== "AttributeGrid") {
+    // This should not happen.
+    throw new Error("Something went wrong while rendering the data.");
+  }
 
-  const fieldsetsWithFieldInfo = section.fieldsets.map(
+  const fieldsetsWithFieldInfo = fieldSetConfigs[0].sections[0].fieldsets.map(
     (fieldset) =>
       [
         fieldset[0],

frontend/src/pages/informatieobjecttypen/InformatieObjectTypenPage.tsx

@@ -1,16 +1,12 @@
 import { Button, Outline } from "@maykin-ui/admin-ui";
 import { useCallback } from "react";
-import { NavLink, Outlet, useLoaderData, useLocation } from "react-router";
+import { NavLink, useLoaderData, useLocation } from "react-router";
 import { getUUIDFromString } from "~/lib/format/string.ts";
 import { components } from "~/types";
 import { ListView } from "~/views";
 
 import { InformatieObjectTypenLoaderData } from "./informatieobjecttype.loader";
 
-export function InformatieObjectTypeParentPage() {
-  return <Outlet />;
-}
-
 export function InformatieObjectTypenPage() {
   const loaderData = useLoaderData<InformatieObjectTypenLoaderData>();
   const { pathname } = useLocation();

frontend/src/routes.tsx

@@ -15,10 +15,7 @@ import {
   zaaktypenLoader,
 } from "~/pages";
 import { InformatieObjectTypeCreatePage } from "~/pages/informatieobjecttypecreate/InformatieObjectTypeCreatePage";
-import {
-  InformatieObjectTypeParentPage,
-  InformatieObjectTypenPage,
-} from "~/pages/informatieobjecttypen";
+import { InformatieObjectTypenPage } from "~/pages/informatieobjecttypen";
 import { informatieobjecttypenLoader } from "~/pages/informatieobjecttypen/informatieobjecttype.loader";
 import { zaaktypeAction } from "~/pages/zaaktype/zaaktype.action.ts";
 
@@ -100,7 +97,7 @@ export const routes: RouteObject[] = [
               {
                 id: "informatieobjecttypen",
                 path: "informatieobjecttypen",
-                element: <InformatieObjectTypeParentPage />,
+                element: <Outlet />,
                 children: [
                   {
                     index: true,
@@ -119,25 +116,6 @@ export const routes: RouteObject[] = [
                     element: <InformatieObjectTypePage />,
                     action: informatieobjecttypeAction,
                     loader: informatieobjecttypeLoader,
-                    // shouldRevalidate: ({ currentUrl, nextUrl }) => {
-                    //   const baseCurrent =
-                    //     currentUrl.origin +
-                    //     currentUrl.pathname +
-                    //     currentUrl.search;
-                    //   const baseNext =
-                    //     nextUrl.origin + nextUrl.pathname + nextUrl.search;
-
-                    //   // If base is the same but hash differs, do NOT revalidate
-                    //   if (
-                    //     baseCurrent === baseNext &&
-                    //     currentUrl.hash !== nextUrl.hash
-                    //   ) {
-                    //     return false;
-                    //   }
-
-                    //   // Otherwise, revalidate
-                    //   return true;
-                    // },
                   },
                 ],
               },