👌 [#302] test: only use wait_for_timeout when browser is webkit

Author: svenvandescheur

backend/src/openbeheer/conftest.py

@@ -18,8 +18,8 @@
 
 
 @pytest.fixture
-def runner(live_server_vcr) -> GherkinRunner:
-    return GherkinRunner(live_server_vcr)
+def runner(live_server_vcr, browser) -> GherkinRunner:
+    return GherkinRunner(live_server_vcr, browser)
 
 
 @pytest.fixture(scope="function")

backend/src/openbeheer/utils/gherkin_e2e.py

@@ -2,7 +2,7 @@
 import re
 
 from furl import furl
-from playwright.sync_api import Locator, Page, expect
+from playwright.sync_api import Browser, Locator, Page, expect
 from pytest_django.live_server_helper import LiveServer
 from zgw_consumers.constants import APITypes
 from zgw_consumers.models import Service
@@ -59,8 +59,9 @@ def test_not_logged_in(page: Page, runner: GherkinRunner):
     understand the test flow and the expected outcomes.
     """
 
-    def __init__(self, live_server: LiveServer):
+    def __init__(self, live_server: LiveServer, browser: Browser) -> None:
         self.live_server = live_server
+        self.browser = browser
 
     @property
     def given(self):
@@ -176,9 +177,11 @@ def user_logs_out(self, page: Page) -> None:
 
             logout_button = page.get_by_role("button", name="Logout")
             logout_button.wait_for()
-            page.wait_for_timeout(
-                120
-            )  # ¯\_(ツ)_/¯ - Attempt to fix flakiness in WebKit
+
+            # ¯\_(ツ)_/¯ - Attempt to fix flakiness in WebKit
+            if self.runner.browser.browser_type.name == "webkit":
+                page.wait_for_timeout(120)
+
             logout_button.click()
 
         # Navigation