Skip to content

Commit e81524e

Browse files
Xaohssvenvandescheur
authored andcommitted
🎨 refactor: improving types
1 parent 78012ad commit e81524e

File tree

2 files changed

+20
-13
lines changed

2 files changed

+20
-13
lines changed

frontend/src/components/archiveform/ArchiveForm.tsx

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,13 +56,23 @@ export function ArchiveForm({
5656
}: ArchiveFormProps) {
5757
const alert = useAlert();
5858

59-
/** Archive metadata from selectielijstklasse (waardering + afleidingswijzen). */
59+
/** Archive metadata from selectielijst klasse (waardering + afleidingswijzen). */
6060
const [archiveMeta, setArchiveMeta] = useState<ArchiveMeta | null>(null);
6161

6262
/** Form field values. */
63-
const [formState, setFormState] = useState<ArchiveFormData>({
64-
selectielijstklasse: resultaatType.selectielijstklasse,
65-
...(resultaatType.brondatumArchiefprocedure as BrondatumFieldValues),
63+
const [formState, setFormState] = useState<ArchiveFormData>(() => {
64+
const resultaatTypeBrondDatumValues =
65+
resultaatType.brondatumArchiefprocedure || {};
66+
return {
67+
selectielijstklasse: resultaatType.selectielijstklasse,
68+
afleidingswijze: "afgehandeld",
69+
datumkenmerk: "",
70+
einddatumBekend: false,
71+
objecttype: "",
72+
registratie: "",
73+
procestermijn: "",
74+
...resultaatTypeBrondDatumValues,
75+
};
6676
});
6777

6878
// Fetch archive metadata on mount or when selectielijstklasse changes.

frontend/src/lib/resultaattype/archive.ts

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -100,15 +100,12 @@ export function getArchiveMetaBySelectielijstResultaatURL(
100100
return [promise, abortController];
101101
}
102102

103-
/**
104-
* Form values for BrondatumFieldName fields
105-
* FIXME: Can't use here as the schema seems to be incorrect and `null` values
106-
* are not accepted (https://github.com/open-zaak/open-zaak/issues/2206)
107-
*/
108-
export type BrondatumFieldValues = Omit<
109-
Record<BrondatumFieldName, string>,
110-
"einddatumBekend"
111-
> & { einddatumBekend: boolean };
103+
export type BrondatumFieldValues = {
104+
[K in BrondatumFieldName]: Exclude<
105+
components["schemas"]["BrondatumArchiefprocedure"][K],
106+
null
107+
>;
108+
};
112109

113110
/**
114111
* Returns the required {@link FormField}s for computing the brondatum

0 commit comments

Comments
 (0)