Skip to content

Commit 595510c

Browse files
committed
fix: serverlessV2MaxCapacity should not be set to 0.5
1 parent 5178050 commit 595510c

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

packages/aws-cdk-lib/aws-rds/lib/cluster.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -985,8 +985,8 @@ abstract class DatabaseClusterNew extends DatabaseClusterBase {
985985
}
986986

987987
private validateServerlessScalingConfig(): void {
988-
if (this.serverlessV2MaxCapacity > 256 || this.serverlessV2MaxCapacity < 0.5) {
989-
throw new Error('serverlessV2MaxCapacity must be >= 0.5 & <= 256');
988+
if (this.serverlessV2MaxCapacity > 256 || this.serverlessV2MaxCapacity < 1) {
989+
throw new Error('serverlessV2MaxCapacity must be >= 1 & <= 256');
990990
}
991991

992992
if (this.serverlessV2MinCapacity > 256 || this.serverlessV2MinCapacity < 0.5) {
@@ -997,9 +997,6 @@ abstract class DatabaseClusterNew extends DatabaseClusterBase {
997997
throw new Error('serverlessV2MaxCapacity must be greater than serverlessV2MinCapacity');
998998
}
999999

1000-
if (this.serverlessV2MaxCapacity === 0.5 && this.serverlessV2MinCapacity === 0.5) {
1001-
throw new Error('If serverlessV2MinCapacity === 0.5 then serverlessV2MaxCapacity must be >=1');
1002-
}
10031000
const regexp = new RegExp(/^[0-9]+\.?5?$/);
10041001
if (!regexp.test(this.serverlessV2MaxCapacity.toString()) || !regexp.test(this.serverlessV2MinCapacity.toString())) {
10051002
throw new Error('serverlessV2MinCapacity & serverlessV2MaxCapacity must be in 0.5 step increments, received '+

packages/aws-cdk-lib/aws-rds/test/cluster.test.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -114,11 +114,10 @@ describe('cluster new api', () => {
114114
});
115115

116116
test.each([
117-
[0.5, 300, /serverlessV2MaxCapacity must be >= 0.5 & <= 256/],
118-
[0.5, 0, /serverlessV2MaxCapacity must be >= 0.5 & <= 256/],
117+
[0.5, 300, /serverlessV2MaxCapacity must be >= 1 & <= 256/],
118+
[0.5, 0, /serverlessV2MaxCapacity must be >= 1 & <= 256/],
119119
[0, 1, /serverlessV2MinCapacity must be >= 0.5 & <= 256/],
120120
[300, 1, /serverlessV2MinCapacity must be >= 0.5 & <= 256/],
121-
[0.5, 0.5, /If serverlessV2MinCapacity === 0.5 then serverlessV2MaxCapacity must be >=1/],
122121
[10.1, 12, /serverlessV2MinCapacity & serverlessV2MaxCapacity must be in 0.5 step increments/],
123122
[12, 12.1, /serverlessV2MinCapacity & serverlessV2MaxCapacity must be in 0.5 step increments/],
124123
[5, 1, /serverlessV2MaxCapacity must be greater than serverlessV2MinCapacity/],

0 commit comments

Comments
 (0)