Skip to content

Commit ba8abf3

Browse files
authored
Merge pull request #123 from mbarbin/inline-comments
Inline comments
2 parents 8054729 + 8687f4b commit ba8abf3

File tree

145 files changed

+322
-292
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

145 files changed

+322
-292
lines changed

.crs-ignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@
33
# would not be grepped as actual CRs. However doing this adds a level of
44
# complexity for new readers and people discovering the project. Ignoring CRs
55
# from the README prevents us from using the CRs workflow in this file. We've
6-
# accepted this tradeof.
6+
# accepted this tradeoff.
77

88
README.md

.vscode/settings.json

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,68 +9,95 @@
99
"autofmt",
1010
"Barbin",
1111
"cadr",
12+
"Caml",
1213
"chdir",
1314
"cmdlang",
1415
"cmdliner",
1516
"cnum",
1617
"codemods",
1718
"compl",
1819
"conv",
20+
"decr",
1921
"defconst",
2022
"defcustom",
2123
"defgroup",
2224
"defun",
2325
"defvar",
26+
"depexts",
2427
"descr",
28+
"destdir",
2529
"Diátaxis",
2630
"docstrings",
2731
"docv",
32+
"dunolint",
2833
"EINTR",
2934
"eldev",
35+
"elif",
3036
"elisp",
3137
"endline",
3238
"execp",
3339
"failwith",
40+
"fboundp",
3441
"fname",
3542
"Fpath",
43+
"fprintf",
3644
"Fsegment",
3745
"getcwd",
46+
"gpatch",
47+
"groupi",
48+
"hideable",
3849
"hlist",
3950
"hpad",
51+
"iteri",
4052
"janestreet",
4153
"jdoe",
4254
"keymap",
55+
"lfindi",
4356
"lnum",
57+
"lsplit",
4458
"lstrip",
59+
"mapi",
4560
"Mathieu",
4661
"mbarbin",
4762
"MELPA",
63+
"nativeint",
4864
"nonrec",
65+
"nontail",
66+
"numpy",
67+
"ocamlformat",
4968
"ocamlmig",
5069
"odoc",
5170
"opam",
71+
"OPAMYES",
5272
"pageantty",
5373
"patdiff",
5474
"pplumbing",
5575
"ppxlib",
76+
"prerr",
5677
"printbox",
5778
"Printexc",
5879
"progn",
80+
"protoc",
5981
"rdjson",
6082
"reindentation",
6183
"reindented",
6284
"relpath",
6385
"repn",
6486
"reviewdog",
87+
"rfindi",
6588
"rstrip",
89+
"rstripped",
90+
"runtest",
6691
"setq",
6792
"sexp",
6893
"sexplib",
6994
"sherlodoc",
7095
"shexp",
7196
"sigpipe",
97+
"softprops",
7298
"sprintf",
7399
"stdlib",
100+
"stdune",
74101
"Streeters",
75102
"stringable",
76103
"stringp",

CHANGES.md

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
## 0.0.202XXXXX (unreleased)
1+
## 0.0.20260202 (2026-02-02)
22

33
Starting from this version we're using GitHub immutable releases.
44

@@ -10,6 +10,8 @@ Starting from this version we're using GitHub immutable releases.
1010

1111
### Changed
1212

13+
- Improve project synopsis and update source headers (#123, @mbarbin).
14+
- Migrate main and doc CIs to `setup-dune` (#122, @mbarbin).
1315
- Increase some lower bounds to ease maintenance (#119, @mbarbin).
1416
- Adapt release artifacts jobs for immutable releases (@mbarbin).
1517
- Make type `User_handle` independent instead of from `Vcs` (#116, @mbarbin).
@@ -117,7 +119,7 @@ Starting from this version we're using GitHub immutable releases.
117119

118120
### Fixed
119121

120-
- Fix rendering of empty lines in multilines CRs with comment prefix (@mbarbin).
122+
- Fix rendering of empty lines in multiline CRs with comment prefix (@mbarbin).
121123

122124
## 0.0.20250626 (2025-06-26)
123125

COPYING.HEADER

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
crs - A tool for managing code review comments embedded in source code
2-
Copyright (C) 2024-2025 Mathieu Barbin <mathieu.barbin@gmail.com>
1+
crs - A tool for managing inline review comments embedded in source code
2+
Copyright (C) 2024-2026 Mathieu Barbin <mathieu.barbin@gmail.com>
33

44
This file is part of crs.
55

NOTICE.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ We've included a copy of Iron's `Apache-2.0` License in the repository [here](./
2626

2727
We're referring to the Iron source code as of `v0.9.114.44+47`, revision `dfb106cb82abf5d16e548d4ee4f419d0994d3644`.
2828

29-
`Iron` includes functionality for interacting with `Mercurial` repositories, and parsing code review comments embedded in source code.
29+
`Iron` includes functionality for interacting with `Mercurial` repositories, and parsing review comments embedded in source code.
3030

3131
To build this project, we've used a format for code review comments almost identical to the syntax used by Iron. Moreover, we have used as a starting point the code from Iron responsible for modeling and parsing the comments.
3232

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77

88
## Introduction
99

10-
Welcome to **crs**, a project that provides libraries and a command-line interface to help manage code review comments embedded directly in source code using a specialized syntax.
10+
Welcome to **crs**, a project that provides libraries and a command-line interface to help manage inline review comments embedded directly in source code using a specialized syntax.
1111

1212
### A Quick Example of a Code Review Comment (CR)
1313

crs.opam

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# This file is generated by dune, edit dune-project instead
22
opam-version: "2.0"
3-
synopsis: "A tool for managing code review comments embedded in source code"
3+
synopsis:
4+
"A tool for managing inline review comments embedded in source code"
45
maintainer: ["Mathieu Barbin <opensource@mbarbin.org>"]
56
authors: ["Mathieu Barbin"]
67
license: "LGPL-3.0-or-later WITH LGPL-3.0-linking-exception"
@@ -50,7 +51,7 @@ build: [
5051
dev-repo: "git+https://github.com/mbarbin/crs.git"
5152
description: """\
5253

53-
The [crs] package provides libraries and a CLI to help manage code
54+
The [crs] package provides libraries and a CLI to help manage inline
5455
review comments embedded directly in source code using a specialized
5556
syntax.
5657

@@ -77,5 +78,5 @@ ideas.
7778
[iron]: https://github.com/janestreet/iron
7879

7980
"""
80-
tags: [ "code-review" ]
81+
tags: [ "code-review" "inline-comments" ]
8182
x-maintenance-intent: [ "(latest)" ]

crs.opam.template

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
description: """\
22

3-
The [crs] package provides libraries and a CLI to help manage code
3+
The [crs] package provides libraries and a CLI to help manage inline
44
review comments embedded directly in source code using a specialized
55
syntax.
66

@@ -27,5 +27,5 @@ ideas.
2727
[iron]: https://github.com/janestreet/iron
2828

2929
"""
30-
tags: [ "code-review" ]
30+
tags: [ "code-review" "inline-comments" ]
3131
x-maintenance-intent: [ "(latest)" ]

doc/blog/2025-07-31-launching-crs-workflows/index.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ tags: [ci, github]
66
---
77

88
**TL;DR:**
9-
🚀 I’m launching CRs Workflows — GitHub Actions for code review comments embedded directly in your source code. They’re new, open source, and looking for adventurous early adopters and collaborators! See real examples and visuals in the linked workflows below.
9+
🚀 I’m launching CRs Workflows — GitHub Actions for inline review comments embedded directly in your source code. They’re new, open source, and looking for adventurous early adopters and collaborators! See real examples and visuals in the linked workflows below.
1010

1111
<!-- truncate -->
1212

1313
They're brand new, simple yet intriguing — and most importantly, they're now available on GitHub: [CRs Workflows](https://github.com/mbarbin/crs-actions) are looking for early adopters.
1414

1515
## Huh? What's a CR?
1616

17-
CRs are code review comments embedded directly in source code! [Learn more here](https://mbarbin.github.io/crs/).
17+
CRs are inline review comments embedded directly in source code! [Learn more here](https://mbarbin.github.io/crs/).
1818

1919
## What's a CR Workflow?
2020

doc/docusaurus.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import type * as Preset from '@docusaurus/preset-classic';
44

55
const config: Config = {
66
title: 'CRs',
7-
tagline: 'A tool for managing code review comments embedded in source code',
7+
tagline: 'A tool for managing inline review comments embedded in source code',
88
// favicon: 'img/favicon.ico',
99

1010
// Set the production url of your site here

0 commit comments

Comments
 (0)