tweak/simplify dependency downloader and improve test coverage

Author: mbdevpl

open_fortran_parser/dependencies.py

@@ -21,7 +21,7 @@ def ensure_dependencies(
         os.makedirs(str(target_dir), exist_ok=True)
     for dependency, (url_root, filename) in dependencies.items():
         path = target_dir.joinpath(filename)
-        if path.is_file():
+        if path.is_file() and not silent:
             _LOG.warning('%s is present already.', dependency)
             continue
         if not download:
@@ -32,13 +32,6 @@ def ensure_dependencies(
         wget.download(url, str(path), bar=None if silent else wget.bar_adaptive)
         if not silent:
             print()
-    if not silent:
-        classpath = target_dir.joinpath('*')
-        _LOG.warning('If you wish to use the Open Fortran Parser XML generator directly,'
-                     ' please add "%s" to your Java classpath:', classpath)
-        if platform.system() != 'Windows':
-            _LOG.warning('export CLASSPATH="${CLASSPATH}:%s"', classpath)
-
 
 def cleanup_old_dependencies(
         outdated_dependencies, current_dir: pathlib.Path,

test/test_dependencies.py

@@ -18,11 +18,15 @@ class Tests(unittest.TestCase):
     @unittest.skipUnless(os.environ.get('TEST_DEPENDENCIES'), 'skipping dependency test')
     def test_deps(self):
         with tempfile.TemporaryDirectory() as temp_dir:
-            ensure_dependencies(DEV_DEPENDENCIES, pathlib.Path(temp_dir), silent=False)
+            self.assertEqual(len(os.listdir(temp_dir)), 0)
+            ensure_dependencies(TESTED_DEPENDENCIES, pathlib.Path(temp_dir), download=False)
+            self.assertEqual(len(os.listdir(temp_dir)), 0)
+            ensure_dependencies(TESTED_DEPENDENCIES, pathlib.Path(temp_dir), silent=False)
             self.assertGreater(len(os.listdir(temp_dir)), 0)
+            ensure_dependencies(TESTED_DEPENDENCIES, pathlib.Path(temp_dir), silent=False)
         with tempfile.TemporaryDirectory() as temp_dir:
             os.rmdir(temp_dir)
-            ensure_dependencies(DEV_DEPENDENCIES, pathlib.Path(temp_dir), silent=True)
+            ensure_dependencies(TESTED_DEPENDENCIES, pathlib.Path(temp_dir), silent=True)
             self.assertGreater(len(os.listdir(temp_dir)), 0)
 
     @unittest.skipUnless(os.environ.get('TEST_DEPENDENCIES'), 'skipping dependency test')