Skip to content

Commit 89182bb

Browse files
committed
chore: cleanup logging setup
1 parent 9dd7a8f commit 89182bb

File tree

5 files changed

+20
-16
lines changed

5 files changed

+20
-16
lines changed

requirements.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
boilerplates[logging] ~= 0.5
12
GitPython ~= 3.1
23
packaging >= 23.0
34
semver ~= 2.13

requirements_test.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
11
-r requirements.txt
22
boilerplates[git_repo_tests,packaging_tests] ~= 0.5
3-
colorlog ~= 6.7
43
setuptools >= 67.4

test/__init__.py

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,15 +3,13 @@
33
import logging
44
import os
55

6-
import colorlog
6+
from version_query.__main__ import Logging
77

8-
_HANDLER = logging.StreamHandler()
9-
_HANDLER.setFormatter(colorlog.ColoredFormatter(
10-
'{name} [{log_color}{levelname}{reset}] {message}', style='{'))
118

12-
logging.basicConfig(level=logging.DEBUG, handlers=[_HANDLER])
13-
logging.getLogger().setLevel(logging.WARNING)
14-
logging.getLogger('version_query').setLevel(
15-
getattr(logging, os.environ.get('LOGGING_LEVEL', 'debug').upper()))
16-
logging.getLogger('test').setLevel(logging.DEBUG)
9+
class TestsLogging(Logging):
10+
"""Logging configuration."""
1711

12+
level_package = logging.DEBUG
13+
14+
15+
TestsLogging.configure_basic()

version_query/__main__.py

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,19 @@
11
"""Entry point of the command-line interface of version_query package."""
22

3+
import logging
4+
5+
import boilerplates.logging
6+
37
from .main import main
48

59

10+
class Logging(boilerplates.logging.Logging):
11+
"""Logging configuration."""
12+
13+
packages = ['version_query']
14+
level_package = logging.INFO
15+
16+
617
if __name__ == '__main__':
18+
Logging().configure_basic()
719
main()

version_query/main.py

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
"""Command-line interface of version_query package."""
22

33
import argparse
4-
import logging
5-
import os
64
import pathlib
75
import sys
86

@@ -16,10 +14,6 @@ def main(args=None, namespace=None) -> None:
1614
1715
Either query or predict version in a given folder according to the arguments.
1816
"""
19-
logging_level = getattr(logging, os.environ.get('LOGGING_LEVEL', 'warning').upper())
20-
logging.basicConfig(level=min(logging_level, logging.WARNING))
21-
logging.getLogger().setLevel(logging.WARNING)
22-
logging.getLogger('version_query').setLevel(logging_level)
2317
parser = argparse.ArgumentParser(
2418
prog='version_query',
2519
description='''Tool for querying current versions of Python packages. Use LOGGING_LEVEL

0 commit comments

Comments
 (0)