Skip to content

Commit 9083ea5

Browse files
committed
test: don't use type hints when calling untyped functions
1 parent 09840c5 commit 9083ea5

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

test/test_version.py

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,19 +25,21 @@ def test_from_str(self):
2525
with self.subTest(version_str=version_str, version_tuple=version_tuple):
2626

2727
py_version = \
28-
pkg_resources.parse_version(version_str) # type: packaging.version.Version
29-
# self.assertIsInstance(
30-
# py_version, packaging.version.Version, msg=(type(py_version), py_version))
28+
pkg_resources.parse_version(version_str)
3129
_LOG.debug('packaging parsed version string %s into %s: %s',
3230
repr(version_str), type(py_version), py_version)
31+
# self.assertIsInstance(
32+
# py_version, packaging.version.Version, msg=(type(py_version), py_version))
3333

3434
try:
35-
sem_version = semver.VersionInfo.parse(version_str) # type: semver.VersionInfo
35+
sem_version = semver.VersionInfo.parse(version_str)
3636
except ValueError:
3737
_LOG.debug('semver could not parse version string %s', repr(version_str))
3838
else:
3939
_LOG.debug('semver parsed version string %s into %s: %s',
4040
repr(version_str), type(sem_version), sem_version)
41+
# self.assertIsInstance(
42+
# sem_version, semver.VersionInfo, msg=(type(sem_version), sem_version))
4143

4244
self.assertEqual(Version.from_str(version_str).to_tuple(), version_tuple)
4345

@@ -76,7 +78,7 @@ def test_from_sem_version(self):
7678
version_tuple = case_to_version_tuple(args, kwargs)
7779
with self.subTest(version_str=version_str, version_tuple=version_tuple):
7880
try:
79-
sem_version = semver.VersionInfo.parse(version_str) # type: semver.VersionInfo
81+
sem_version = semver.VersionInfo.parse(version_str)
8082
except ValueError:
8183
continue
8284
else:

0 commit comments

Comments
 (0)