Skip to content

Commit 29b7035

Browse files
Clarify comments
1 parent f4cfd04 commit 29b7035

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

connectivity/drivers/emac/TARGET_NUVOTON_EMAC/TARGET_M480/NuvotonM480EthMAC.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ CompositeEMAC::ErrCode NuvotonM480EthMAC::MACDriver::init() {
7777
EMAC_CAMCTL_ABP_Msk;
7878

7979
// Maximum frame length.
80-
// Don't know exactly why, but need to set this 4 bytes higher than the MTU of 1514 bytes
80+
// This apparently includes the CRC, so we need to set this 4 bytes higher than the MTU of 1514 bytes
8181
// or 1514 byte packets get rejected
8282
base->MRFL = 1518;
8383

connectivity/netsocket/mbed_lib.json5

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@
124124
// The M480 EMAC sadly does not support splitting one frame across multiple Rx descriptors.
125125
// So, we need to make each Rx descriptor large enough to fit a max size Ethernet packet.
126126
// Normally that would be 1518 (1514 byte MTU plus 4 bytes for alignment overhead), but this EMAC also always
127-
// receives the CRC (plus other stuff??) at the end of the packet, with no way to turn it off. So, we need an extra 6
127+
// receives the CRC and length at the end of the packet, with no way to turn it off. So, we need an extra 6
128128
// bytes padding that can be clobbered here.
129129
"emac-rx-pool-buf-size": 1524,
130130
}

0 commit comments

Comments
 (0)