Skip to content

Commit a2cddce

Browse files
Set 4 byte addressing support to disabled to match comment
1 parent 90e6b8c commit a2cddce

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

storage/blockdevice/COMPONENT_QSPIF/source/QSPIFBlockDevice.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1114,14 +1114,15 @@ int QSPIFBlockDevice::_handle_vendor_quirks()
11141114
// Macronix devices have several quirks:
11151115
// 1. Have one status register and several config registers, with a nonstandard instruction for reading the config registers
11161116
// 2. Require setting a "fast mode" bit in config register 2 to operate at higher clock rates (if config register 2 exists)
1117-
// 3. Should never attempt to enable 4-byte addressing (it causes reads and writes to fail)
1117+
// 3. Should never attempt to enable 4-byte addressing (it causes reads and writes to fail). On MX25L12833F at least, the
1118+
// SFDP table claims to have 4-byte support but it actually does not!
11181119
tr_debug("Applying quirks for macronix");
11191120
_num_status_registers = MBED_CONF_QSPI_MACRONIX_NUM_STATUS_REGISTER;
11201121
_read_status_reg_2_inst = QSPIF_INST_RDCR;
1121-
if (MBED_CONF_QSPI_MACRONIX_NUM_STATUS_REGISTER >= 3) {
1122+
if(MBED_CONF_QSPI_MACRONIX_NUM_STATUS_REGISTER >= 3) {
11221123
_needs_fast_mode = true;
11231124
}
1124-
break;
1125+
_attempt_4_byte_addressing = false;
11251126
case 0x9d:
11261127
// ISSI devices have only one status register
11271128
tr_debug("Applying quirks for ISSI");

0 commit comments

Comments
 (0)