Don't use whole-archive linking (#71)

* First attempt at converting to OBJECT libraries.  Not working due to more object library limitations

* Only compile the main libraries as OBJECT, because that's all that CMake can be made to do right now.

* Fix availability of target-specific flags

* Missed some usages

* Fix some STM32 ethernet stuff that was not linking correctly

* More fixes for STM32 ethernet and weak symbols

* Fix prebuilt object file linking for MUSCA_S1

* Fix STM32 eth init license headers

Author: Jamie Smith

CMakeLists.txt

@@ -264,23 +264,20 @@ add_subdirectory(cmsis/device/rtos EXCLUDE_FROM_ALL)
 # Create top-level targets  ----------------------------------------------------------------------------------
 
 if(NOT MBED_IS_NATIVE_BUILD)
-
-    # Create a distro for the microcontroller cmake target, ensuring its sources are only compiled once
-    mbed_create_distro(${MBED_TARGET_CMAKE_NAME}-lib ${MBED_TARGET_CMAKE_NAME} mbed-core-flags)
-
-    # Set up the linker script and hook it up to the MCU cmake target
-    mbed_setup_linker_script(${MBED_TARGET_CMAKE_NAME}-lib)
-
-    # Now make the Mbed OS code depend on the target, ensuring everything has access to the uC's flags and objects.
-    target_link_libraries(mbed-core-flags INTERFACE ${MBED_TARGET_CMAKE_NAME}-lib)
-
     # Core Mbed OS libraries
     # mbed-baremetal contains baremetal sources + target sources + target compile flags.
     # mbed-os will be a superset of mbed-baremetal, also containing the RTOS sources and RTOS flags.
     # Note that many different source files will compile differently depending on if the RTOS is in use.
     # So, it's needed to compile the core sources twice, once for RTOS and once for non-RTOS.
-    mbed_create_distro(mbed-baremetal mbed-core-flags mbed-core-sources)
-    mbed_create_distro(mbed-os mbed-core-flags mbed-core-sources mbed-rtos-flags mbed-rtos-sources)
+    mbed_create_distro(mbed-baremetal ${MBED_TARGET_CMAKE_NAME} mbed-core-flags mbed-core-sources)
+    mbed_create_distro(mbed-os ${MBED_TARGET_CMAKE_NAME} mbed-core-flags mbed-core-sources mbed-rtos-flags mbed-rtos-sources)
+
+    # Set up the linker script and hook it up to the top-level OS targets
+    mbed_setup_linker_script(mbed-baremetal mbed-os)
+
+    # Make sure that things linking mbed-core-flags can also get the target-specific include dirs and flags.
+    mbed_extract_flags(${MBED_TARGET_CMAKE_NAME}-flags ${MBED_TARGET_CMAKE_NAME})
+    target_link_libraries(mbed-core-flags INTERFACE ${MBED_TARGET_CMAKE_NAME}-flags)
 endif()
 
 # Ninja requires to be forced for response files

connectivity/drivers/emac/TARGET_STM/CMakeLists.txt

@@ -19,5 +19,4 @@ target_include_directories(mbed-emac
 target_sources(mbed-emac
     PRIVATE
         stm32xx_emac.cpp
-        stm32xx_eth_irq_callback.cpp
 )

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F2/TARGET_NUCLEO_F207ZG/stm32f2_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -117,3 +119,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F4/TARGET_ARCH_MAX/stm32f4_eth_init.c

@@ -1,3 +1,33 @@
+/* mbed Microcontroller Library
+ * Copyright (c) 2022, STMicroelectronics
+ * All rights reserved.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ * 1. Redistributions of source code must retain the above copyright notice,
+ *    this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright notice,
+ *    this list of conditions and the following disclaimer in the documentation
+ *    and/or other materials provided with the distribution.
+ * 3. Neither the name of STMicroelectronics nor the names of its contributors
+ *    may be used to endorse or promote products derived from this software
+ *    without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
 #include "stm32f4xx_hal.h"
 
 /**
@@ -79,3 +109,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
         NVIC_DisableIRQ(ETH_IRQn);
     }
 }
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F4/TARGET_NUCLEO_F429ZI/stm32f4_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -117,3 +119,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F4/TARGET_NUCLEO_F439ZI/stm32f4_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -117,3 +119,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F7/TARGET_DISCO_F746NG/stm32f7_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -116,3 +118,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F7/TARGET_DISCO_F769NI/stm32f7_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -122,3 +124,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F7/TARGET_NUCLEO_F746ZG/stm32f7_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -122,3 +124,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}

connectivity/drivers/emac/TARGET_STM/TARGET_STM32F7/TARGET_NUCLEO_F756ZG/stm32f7_eth_init.c

@@ -1,7 +1,9 @@
 /* mbed Microcontroller Library
- * Copyright (c) 2018, STMicroelectronics
+ * Copyright (c) 2022, STMicroelectronics
  * All rights reserved.
  *
+ * SPDX-License-Identifier: Apache-2.0
+ *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are met:
  *
@@ -122,3 +124,7 @@ void HAL_ETH_MspDeInit(ETH_HandleTypeDef *heth)
 }
 
 #endif /* USE_USER_DEFINED_HAL_ETH_MSPINIT */
+
+// Blank, non-weak-override function to make sure the linker pulls in this file
+void stm32_eth_init_weak_symbol_helper()
+{}