Skip to content

Commit e134df9

Browse files
Rename USB variables
1 parent a53a8c3 commit e134df9

File tree

3 files changed

+23
-22
lines changed

3 files changed

+23
-22
lines changed

.github/workflows/greentea_cmake.yml

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,14 +143,15 @@ jobs:
143143
144144
- name: Build ${{ matrix.target }} with baremetal profile
145145
if: ${{ matrix.profile == 'baremetal' }}
146+
# Note: We have to set a wifi network name and password so that the test will compile on devices that use wifi
146147
run: |
147148
rm -rf __build
148-
cmake -S . -B __build -GNinja -DUPLOAD_METHOD=NONE -DCMAKE_CTEST_ARGUMENTS="--output-on-failure;-V" -DMBED_BUILD_GREENTEA_TESTS=ON -DMBED_GREENTEA_TEST_BAREMETAL=ON -DMBED_GREENTEA_SERIAL_PORT=/dev/ttyDUMMY -DMBED_TARGET=${{ matrix.target }} -DMBED_APP_JSON_PATH=TESTS/configs/baremetal.json
149+
cmake -S . -B __build -GNinja -DUPLOAD_METHOD=NONE -DMBED_GREENTEA_WIFI_SECURE_SSID=SomeNetwork MBED_GREENTEA_WIFI_SECURE_PASSWORD=SomePassword -DCMAKE_CTEST_ARGUMENTS="--output-on-failure;-V" -DMBED_BUILD_GREENTEA_TESTS=ON -DMBED_GREENTEA_TEST_BAREMETAL=ON -DMBED_GREENTEA_SERIAL_PORT=/dev/ttyDUMMY -DMBED_TARGET=${{ matrix.target }} -DMBED_APP_JSON_PATH=TESTS/configs/baremetal.json
149150
cmake --build __build
150151
151152
- name: Build ${{ matrix.target }} with full profile
152153
if: ${{ matrix.profile == 'full' }}
153154
run: |
154155
rm -rf __build
155-
cmake -S . -B __build -GNinja -DUPLOAD_METHOD=NONE -DCMAKE_CTEST_ARGUMENTS="--output-on-failure;-V" -DMBED_BUILD_GREENTEA_TESTS=ON -DMBED_GREENTEA_SERIAL_PORT=/dev/ttyDUMMY -DMBED_TARGET=${{ matrix.target }}
156+
cmake -S . -B __build -GNinja -DUPLOAD_METHOD=NONE -DMBED_GREENTEA_WIFI_SECURE_SSID=SomeNetwork MBED_GREENTEA_WIFI_SECURE_PASSWORD=SomePassword -DCMAKE_CTEST_ARGUMENTS="--output-on-failure;-V" -DMBED_BUILD_GREENTEA_TESTS=ON -DMBED_GREENTEA_SERIAL_PORT=/dev/ttyDUMMY -DMBED_TARGET=${{ matrix.target }}
156157
cmake --build __build

drivers/usb/include/usb/internal/Task.h

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ namespace events {
2929
*/
3030

3131

32-
template<typename F, typename A1 = void, typename A2 = void, typename A3 = void, typename A4 = void, typename A5 = void>
32+
template<typename F, typename ARG1 = void, typename ARG2 = void, typename ARG3 = void, typename ARG4 = void, typename ARG5 = void>
3333
struct AllArgs;
3434

3535
template<typename B0>
@@ -543,24 +543,24 @@ class Task<R()>: public TaskBase {
543543
All _args;
544544
};
545545

546-
template <typename R, typename A0>
547-
class Task<R(A0)>: public TaskBase {
546+
template <typename R, typename ARG0>
547+
class Task<R(ARG0)>: public TaskBase {
548548
public:
549549

550-
Task(TaskQueue *q = NULL, mbed::Callback<R(A0)> cb = mbed::Callback<R(A0)>())
550+
Task(TaskQueue *q = NULL, mbed::Callback<R(ARG0)> cb = mbed::Callback<R(ARG0)>())
551551
: TaskBase(q), _args(cb)
552552
{
553553
}
554554

555-
Task &operator=(mbed::Callback<R(A0)> cb)
555+
Task &operator=(mbed::Callback<R(ARG0)> cb)
556556
{
557557
_args.b0 = cb;
558558
return *this;
559559
}
560560

561-
void call(A0 a0)
561+
void call(ARG0 arg0)
562562
{
563-
_args.b1 = a0;
563+
_args.b1 = arg0;
564564
post();
565565
}
566566

@@ -578,16 +578,16 @@ class Task<R(A0)>: public TaskBase {
578578
}
579579

580580
private:
581-
typedef AllArgs<mbed::Callback<R(A0)>, A0> All;
581+
typedef AllArgs<mbed::Callback<R(ARG0)>, ARG0> All;
582582
All _args;
583583
};
584584

585585
/** Task
586586
*
587587
* Representation of a postable task
588588
*/
589-
template <typename R, typename A0, typename A1>
590-
class Task<R(A0, A1)>: public TaskBase {
589+
template <typename R, typename ARG0, typename ARG1>
590+
class Task<R(ARG0, ARG1)>: public TaskBase {
591591
public:
592592

593593
/**
@@ -596,7 +596,7 @@ class Task<R(A0, A1)>: public TaskBase {
596596
* @param q TaskQueue to post to
597597
* @param cb Callback to run
598598
*/
599-
Task(TaskQueue *q = NULL, mbed::Callback<R(A0, A1)> cb = mbed::Callback<R(A0, A1)>())
599+
Task(TaskQueue *q = NULL, mbed::Callback<R(ARG0, ARG1)> cb = mbed::Callback<R(ARG0, ARG1)>())
600600
: TaskBase(q), _args(cb)
601601
{
602602
}
@@ -606,7 +606,7 @@ class Task<R(A0, A1)>: public TaskBase {
606606
*
607607
* @param cb Callback to run
608608
*/
609-
Task &operator=(mbed::Callback<R(A0, A1)> cb)
609+
Task &operator=(mbed::Callback<R(ARG0, ARG1)> cb)
610610
{
611611
_args.b0 = cb;
612612
return *this;
@@ -620,13 +620,13 @@ class Task<R(A0, A1)>: public TaskBase {
620620
* expects two integers as arguments to call, while Task<void()>
621621
* expects no arguments.
622622
*
623-
* @param a0 First callback parameter
624-
* @param a1 Second callback parameter
623+
* @param arg0 First callback parameter
624+
* @param arg1 Second callback parameter
625625
*/
626-
void call(A0 a0, A1 a1)
626+
void call(ARG0 arg0, ARG1 arg1)
627627
{
628-
_args.b1 = a0;
629-
_args.b2 = a1;
628+
_args.b1 = arg0;
629+
_args.b2 = arg1;
630630
post();
631631
}
632632

@@ -644,7 +644,7 @@ class Task<R(A0, A1)>: public TaskBase {
644644
}
645645

646646
private:
647-
typedef AllArgs<mbed::Callback<R(A0, A1)>, A0, A1> All;
647+
typedef AllArgs<mbed::Callback<R(ARG0, ARG1)>, ARG0, ARG1> All;
648648
All _args;
649649
};
650650

drivers/usb/tests/TESTS/usb_device/msd/main.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -243,14 +243,14 @@ void msd_process(USBMSD *msd)
243243

244244
#define TEST_ASSERT_EQUAL_STRING_LOOP(expected, actual, loop_index) \
245245
if (strcmp(expected, actual) != 0) { \
246-
char str[128]; \
246+
char str[255]; \
247247
sprintf(str, "expected %s was %s (loop index: %lu)", expected, actual, loop_index); \
248248
TEST_ASSERT_MESSAGE(false, str); \
249249
}
250250

251251
#define TEST_ASSERT_EQUAL_LOOP(expected, actual, loop_index) \
252252
if (expected != actual) { \
253-
char str[128]; \
253+
char str[255]; \
254254
sprintf(str, "expected %d was %d (loop index: %lu)", expected, actual, loop_index); \
255255
TEST_ASSERT_MESSAGE(false, str); \
256256
}

0 commit comments

Comments
 (0)