Skip to content

littlefs2: Properly init class variables #451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

littlefs2: Properly init class variables #451

merged 2 commits into from
Apr 17, 2025

Conversation

@multiplemonomials
Copy link
Collaborator

@multiplemonomials multiplemonomials commented Apr 15, 2025

Summary of changes

Noticed this bug on the Arduino bug tracker which is happening due to this->_bd being uninitialized in LittleFileSystem2, leading to undefined behavior if unmount() is called after constructing the class.

Impact of changes

Should no longer crash in this situation.

Migration actions required

Documentation

None

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

@multiplemonomials multiplemonomials self-assigned this Apr 15, 2025
@multiplemonomials multiplemonomials mentioned this pull request Apr 15, 2025
Open
@multiplemonomials multiplemonomials merged commit e420c07 into master Apr 17, 2025
52 checks passed
@multiplemonomials multiplemonomials deleted the bugfix/lfsv2-init-class-vars branch April 17, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnK1987 JohnK1987 JohnK1987 approved these changes

Assignees

@multiplemonomials multiplemonomials

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@multiplemonomials @JohnK1987