Fix some M480 I2C issues causing test shield test failures #461
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
I am working on testing the M480 board using our CI Test Shield, which can do exhaustive tests of things like I2C, SPI, and PWM to ensure that they are implemented correctly. These tests are much more in-depth than the tests that ARM's CI shield did, and should be able to root out a great deal more issues.
First step was testing I2C, and the M480 was actually VERY close to passing all the tests -- I'm impressed, few boards I've tested have worked this well out of the box!
However, I did find two small issues in the I2C implementation that should be addressed:
I was able to fix these by making some tweaks to the I2C code, and now all tests pass!
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Test shield I2C tests pass!