HHH-19876 Do not consider each and every project and system property a configuration cache input

Author: Vampire

hibernate-core/hibernate-core.gradle

@@ -277,7 +277,7 @@ tasks.withType( Test.class ).each { test ->
         // Most systems have multi-threading and maxing out a core on both threads will hurt performance
         // Also, as soon as we hit 16+ threads, the returns are diminishing, so divide by 4
         def threadCount = Runtime.runtime.availableProcessors()
-        def testThreads = project.getProperties().get( "test.threads" )
+        def testThreads = project.findProperty( "test.threads" )
         if ( testThreads == null ) {
             testThreads = threadCount >= 16 ? threadCount.intdiv( 4 ) : (threadCount.intdiv( 2 ) ?: 1)
         }

hibernate-envers/hibernate-envers.gradle

@@ -62,7 +62,7 @@ tasks.withType( Test.class ).each { test ->
         // Most systems have multi-threading and maxing out a core on both threads will hurt performance
         // Also, as soon as we hit 16+ threads, the returns are diminishing, so divide by 4
         def threadCount = Runtime.runtime.availableProcessors()
-        def testThreads = project.getProperties().get( "test.threads" )
+        def testThreads = project.findProperty( "test.threads" )
         if ( testThreads == null ) {
             testThreads = threadCount >= 16 ? threadCount.intdiv( 4 ) : (threadCount.intdiv( 2 ) ?: 1)
         }

local-build-plugins/src/main/groovy/local.java-module.gradle

@@ -215,7 +215,7 @@ tasks.withType( Test.class ).each { test ->
     test.systemProperties['hibernate.testing.bytecode.enhancement.extension.engine.enabled'] = true
     test.systemProperties['hibernate.test.validatefailureexpected'] = true
     test.systemProperties['hibernate.highlight_sql'] = false
-    test.systemProperties += System.properties.findAll { it.key.startsWith( "hibernate." ) }
+    test.systemProperties += providers.systemPropertiesPrefixedBy("hibernate.").get()
 
     test.enableAssertions = true
 

local-build-plugins/src/main/java/org/hibernate/orm/db/DatabaseServicePlugin.java

@@ -27,7 +27,7 @@ public void apply(Project project) {
 				DatabaseService.class,
 				spec -> spec.getMaxParallelUsages().set( 1 )
 		);
-		final String database = (String) project.getProperties().get( "db" );
+		final String database = (String) project.findProperty( "db" );
 
 		// H2 and HSQLDB are in-memory, so there is no sharing that needs to be avoided
 		if ( database != null && !"h2".equals( database ) && !"hsqldb".equals( database ) ) {

local-build-plugins/src/main/java/org/hibernate/orm/toolchains/JavaModulePlugin.java

@@ -123,7 +123,7 @@ public void execute(Test testTask) {
 				if ( project.hasProperty( "test.jdk.launcher.args" ) ) {
 					testTask.jvmArgs(
 							Arrays.asList(
-								project.getProperties().get( "test.jdk.launcher.args" ).toString().split( " " )
+								project.property( "test.jdk.launcher.args" ).toString().split( " " )
 							)
 					);
 				}

local-build-plugins/src/main/java/org/hibernate/orm/toolchains/JdkVersionConfig.java

@@ -217,12 +217,12 @@ public static JavaLanguageVersion extractVersion(Settings settings, String prope
 	}
 
 	public static JavaLanguageVersion extractVersion(Project project, String propertyName) {
-		final Object projectProp = project.getProperties().get( propertyName );
+		final Object projectProp = project.findProperty( propertyName );
 		if ( projectProp != null ) {
 			return JavaLanguageVersion.of( projectProp.toString() );
 		}
 
-		final Object sysProp = System.getProperties().get( propertyName );
+		final Object sysProp = System.getProperty( propertyName );
 		if ( sysProp != null ) {
 			return JavaLanguageVersion.of( sysProp.toString() );
 		}