Remove IDE validation from flutter doctor (flutter#171924)

Closes flutter#61246.

I open to doing this behind a flag, but given we decided already 5 years
ago to do this, I'm leaning limiting this to an announcement
(`flutter-announce@`) and just landing this cleanup.

Open to suggestions.

Author: matanlurey

packages/flutter_tools/lib/src/android/android_studio.dart

@@ -14,7 +14,11 @@ import '../base/version.dart';
 import '../convert.dart';
 import '../globals.dart' as globals;
 import '../ios/plist_parser.dart';
-import 'android_studio_validator.dart';
+
+const _androidStudioTitle = 'Android Studio';
+const _androidStudioId = 'AndroidStudio';
+const _androidStudioPreviewTitle = 'Android Studio Preview';
+const _androidStudioPreviewId = 'AndroidStudioPreview';
 
 // Android Studio layout:
 
@@ -351,6 +355,11 @@ class AndroidStudio {
         .toList();
   }
 
+  static const _idToTitle = <String, String>{
+    _androidStudioId: _androidStudioTitle,
+    _androidStudioPreviewId: _androidStudioPreviewTitle,
+  };
+
   static List<AndroidStudio> _allLinuxOrWindows() {
     final studios = <AndroidStudio>[];
 
@@ -415,7 +424,7 @@ class AndroidStudio {
       }
       for (final Directory dir in cacheDir.listSync().whereType<Directory>()) {
         final String name = globals.fs.path.basename(dir.path);
-        AndroidStudioValidator.idToTitle.forEach((String id, String title) {
+        _idToTitle.forEach((String id, String title) {
           if (name.startsWith(id)) {
             final String version = name.substring(id.length);
             String? installPath;

packages/flutter_tools/lib/src/android/android_studio_validator.dart

@@ -8,7 +8,6 @@ import 'package:meta/meta.dart';
 import 'package:process/process.dart';
 import 'package:unified_analytics/unified_analytics.dart';
 
-import 'android/android_studio_validator.dart';
 import 'android/android_workflow.dart';
 import 'artifacts.dart';
 import 'base/async_guard.dart';
@@ -30,15 +29,13 @@ import 'doctor_validator.dart';
 import 'features.dart';
 import 'globals.dart' as globals;
 import 'http_host_validator.dart';
-import 'intellij/intellij_validator.dart';
 import 'linux/linux_doctor.dart';
 import 'linux/linux_workflow.dart';
 import 'macos/macos_workflow.dart';
 import 'macos/xcode_validator.dart';
 import 'proxy_validator.dart';
 import 'tester/flutter_tester.dart';
 import 'version.dart';
-import 'vscode/vscode_validator.dart';
 import 'web/chrome.dart';
 import 'web/web_validator.dart';
 import 'web/workflow.dart';
@@ -49,23 +46,17 @@ import 'windows/windows_workflow.dart';
 abstract class DoctorValidatorsProvider {
   // Allow tests to construct a [_DefaultDoctorValidatorsProvider] with explicit
   // [FeatureFlags].
-  factory DoctorValidatorsProvider.test({
-    Platform? platform,
-    Logger? logger,
-    required FeatureFlags featureFlags,
-  }) {
+  factory DoctorValidatorsProvider.test({Platform? platform, required FeatureFlags featureFlags}) {
     return _DefaultDoctorValidatorsProvider(
       featureFlags: featureFlags,
       platform: platform ?? FakePlatform(),
-      logger: logger ?? BufferLogger.test(),
     );
   }
 
   /// The singleton instance, pulled from the [AppContext].
   static DoctorValidatorsProvider get _instance => context.get<DoctorValidatorsProvider>()!;
 
   static final DoctorValidatorsProvider defaultInstance = _DefaultDoctorValidatorsProvider(
-    logger: globals.logger,
     platform: globals.platform,
     featureFlags: featureFlags,
   );
@@ -75,17 +66,12 @@ abstract class DoctorValidatorsProvider {
 }
 
 class _DefaultDoctorValidatorsProvider implements DoctorValidatorsProvider {
-  _DefaultDoctorValidatorsProvider({
-    required this.platform,
-    required this.featureFlags,
-    required Logger logger,
-  }) : _logger = logger;
+  _DefaultDoctorValidatorsProvider({required this.platform, required this.featureFlags});
 
   List<DoctorValidator>? _validators;
   List<Workflow>? _workflows;
   final Platform platform;
   final FeatureFlags featureFlags;
-  final Logger _logger;
 
   late final linuxWorkflow = LinuxWorkflow(platform: platform, featureFlags: featureFlags);
 
@@ -100,25 +86,6 @@ class _DefaultDoctorValidatorsProvider implements DoctorValidatorsProvider {
     if (_validators != null) {
       return _validators!;
     }
-
-    final ideValidators = <DoctorValidator>[
-      if (androidWorkflow!.appliesToHostPlatform)
-        ...AndroidStudioValidator.allValidators(
-          globals.config,
-          platform,
-          globals.fs,
-          globals.userMessages,
-        ),
-      ...IntelliJValidator.installedValidators(
-        fileSystem: globals.fs,
-        platform: platform,
-        userMessages: globals.userMessages,
-        plistParser: globals.plistParser,
-        processManager: globals.processManager,
-        logger: _logger,
-      ),
-      ...VsCodeValidator.installedValidators(globals.fs, platform, globals.processManager),
-    ];
     final proxyValidator = ProxyValidator(platform: platform);
     _validators = <DoctorValidator>[
       FlutterValidator(
@@ -172,7 +139,6 @@ class _DefaultDoctorValidatorsProvider implements DoctorValidatorsProvider {
           userMessages: globals.userMessages,
         ),
       if (windowsWorkflow!.appliesToHostPlatform) visualStudioValidator!,
-      if (ideValidators.isNotEmpty) ...ideValidators else NoIdeValidator(),
       if (proxyValidator.shouldShow) proxyValidator,
       if (globals.deviceManager?.canListAnything ?? false)
         DeviceValidator(deviceManager: globals.deviceManager, userMessages: globals.userMessages),

packages/flutter_tools/lib/src/doctor.dart

@@ -2,9 +2,6 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-/// @docImport 'intellij_validator.dart';
-library;
-
 import 'package:archive/archive.dart';
 
 import '../base/file_system.dart';
@@ -35,10 +32,6 @@ import '../doctor_validator.dart';
 ///
 /// Intellij Flutter plugin's files can be found here:
 ///   https://plugins.jetbrains.com/plugin/9212-flutter/versions/stable
-///
-/// See also:
-///   * [IntelliJValidator], the validator base class that uses this to check
-///     plugin versions.
 class IntelliJPlugins {
   IntelliJPlugins(this.pluginsPath, {required FileSystem fileSystem}) : _fileSystem = fileSystem;