Skip to content

Commit 94fb2ce

Browse files
xVemumboetger
authored andcommitted
Fix logic statements in year2023 documentation (flutter#174120)
<!-- Thanks for filing a pull request! Reviewers are typically assigned within a week of filing a request. To learn more about code review, see our documentation on Tree Hygiene: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md --> If year2023 (old specification) is true, then the indicator doesn't have stop and gap. Not the other way around. ## Pre-launch Checklist - [ ] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [ ] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [ ] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [ ] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [ ] I added new tests to check the change I am making, or this PR is [test-exempt]. - [ ] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [ ] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 1128ff7 commit 94fb2ce

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

packages/flutter/lib/src/material/progress_indicator.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -381,7 +381,7 @@ class LinearProgressIndicator extends ProgressIndicator {
381381

382382
/// The color of the stop indicator.
383383
///
384-
/// If [year2023] is false or [ThemeData.useMaterial3] is false, then no stop
384+
/// If [year2023] is true or [ThemeData.useMaterial3] is false, then no stop
385385
/// indicator will be drawn.
386386
///
387387
/// If null, then the [ProgressIndicatorThemeData.stopIndicatorColor] will be used.
@@ -390,7 +390,7 @@ class LinearProgressIndicator extends ProgressIndicator {
390390

391391
/// The radius of the stop indicator.
392392
///
393-
/// If [year2023] is false or [ThemeData.useMaterial3] is false, then no stop
393+
/// If [year2023] is true or [ThemeData.useMaterial3] is false, then no stop
394394
/// indicator will be drawn.
395395
///
396396
/// Set [stopIndicatorRadius] to 0 to hide the stop indicator.
@@ -401,7 +401,7 @@ class LinearProgressIndicator extends ProgressIndicator {
401401

402402
/// The gap between the indicator and the track.
403403
///
404-
/// If [year2023] is false or [ThemeData.useMaterial3] is false, then no track
404+
/// If [year2023] is true or [ThemeData.useMaterial3] is false, then no track
405405
/// gap will be drawn.
406406
///
407407
/// Set [trackGap] to 0 to hide the track gap.
@@ -811,7 +811,7 @@ class CircularProgressIndicator extends ProgressIndicator {
811811

812812
/// The gap between the active indicator and the background track.
813813
///
814-
/// If [year2023] is false or [ThemeData.useMaterial3] is false, then no track
814+
/// If [year2023] is true or [ThemeData.useMaterial3] is false, then no track
815815
/// gap will be drawn.
816816
///
817817
/// Set [trackGap] to 0 to hide the track gap.

packages/flutter/lib/src/material/progress_indicator_theme.dart

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,13 +86,13 @@ class ProgressIndicatorThemeData with Diagnosticable {
8686

8787
/// Overrides the stop indicator color of the [LinearProgressIndicator].
8888
///
89-
/// If [LinearProgressIndicator.year2023] is false or [ThemeData.useMaterial3]
89+
/// If [LinearProgressIndicator.year2023] is true or [ThemeData.useMaterial3]
9090
/// is false, then no stop indicator will be drawn.
9191
final Color? stopIndicatorColor;
9292

9393
/// Overrides the stop indicator radius of the [LinearProgressIndicator].
9494
///
95-
/// If [LinearProgressIndicator.year2023] is false or [ThemeData.useMaterial3]
95+
/// If [LinearProgressIndicator.year2023] is true or [ThemeData.useMaterial3]
9696
/// is false, then no stop indicator will be drawn.
9797
final double? stopIndicatorRadius;
9898

@@ -110,10 +110,10 @@ class ProgressIndicatorThemeData with Diagnosticable {
110110

111111
/// Overrides the active indicator and the background track.
112112
///
113-
/// If [CircularProgressIndicator.year2023] is false or [ThemeData.useMaterial3]
113+
/// If [CircularProgressIndicator.year2023] is true or [ThemeData.useMaterial3]
114114
/// is false, then no track gap will be drawn.
115115
///
116-
/// If [LinearProgressIndicator.year2023] is false or [ThemeData.useMaterial3]
116+
/// If [LinearProgressIndicator.year2023] is true or [ThemeData.useMaterial3]
117117
/// is false, then no track gap will be drawn.
118118
final double? trackGap;
119119

packages/flutter/lib/src/material/slider_theme.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -631,7 +631,7 @@ class SliderThemeData with Diagnosticable {
631631
/// The Slider defaults to [GappedSliderTrackShape] when the track shape is
632632
/// not specified, and the [trackGap] can be used to adjust the gap size.
633633
///
634-
/// If [Slider.year2023] is false or [ThemeData.useMaterial3] is false, then
634+
/// If [Slider.year2023] is true or [ThemeData.useMaterial3] is false, then
635635
/// the Slider track shape defaults to [RoundedRectSliderTrackShape] and the
636636
/// [trackGap] is ignored. In this case, set the track shape to
637637
/// [GappedSliderTrackShape] to use the [trackGap].

0 commit comments

Comments
 (0)