Fix GUI crash on job completion...

Author: mbruel

src/FoldersMonitorForNewFiles.h

@@ -28,7 +28,7 @@
 #include <QFileInfoList>
 #include <QMap>
 #include <QSet>
-using QAtomicBool = QAtomicInteger<unsigned short>; // 16 bit only (faster than using 8 bit variable...)
+using AtomicBool = QAtomicInteger<unsigned short>; // 16 bit only (faster than using 8 bit variable...)
 using PathSet = QSet<QString>;
 
 class FolderScan
@@ -52,7 +52,7 @@ class FoldersMonitorForNewFiles : public QObject
 private:
     QFileSystemWatcher          _monitor;        //!< monitor
     QMap<QString, FolderScan*>  _folders; //!< track files processed (their date might be > _lastCheck)
-    QAtomicBool                 _stopListening;
+    AtomicBool                  _stopListening;
 
     static const ulong sMSleep = 1000; //!< 1sec in case we move file from samba or unrar when the system is quite loaded
 

src/NgPost.h

@@ -53,9 +53,6 @@ class NzbCheck;
 
 #define NB_ARTICLES_TO_PREPARE_PER_CONNECTION 3
 
-
-//using QAtomicBool = QAtomicInteger<unsigned short>; // 16 bit only (faster than using 8 bit variable...)
-
 #include <QTimer>
 
 /*!

src/PostingJob.cpp

@@ -411,7 +411,8 @@ void PostingJob::onDisconnectedConnection(NntpConnection *con)
             if (con->hasNoMoreFiles())
             {
                 _finishPosting();
-                emit noMoreConnection();
+                if (!_postFinished)
+                    emit noMoreConnection();
             }
             else
             {
@@ -426,7 +427,8 @@ void PostingJob::onDisconnectedConnection(NntpConnection *con)
                 else
                 {
                     _finishPosting();
-                    emit noMoreConnection();
+                    if (!_postFinished)
+                        emit noMoreConnection();
                 }
             }
         }

src/PostingJob.h

@@ -40,7 +40,7 @@ class NntpArticle;
 class PostingWidget;
 class Poster;
 
-using QAtomicBool = QAtomicInteger<unsigned short>; // 16 bit only (faster than using 8 bit variable...)
+using AtomicBool = QAtomicInteger<unsigned short>; // 16 bit only (faster than using 8 bit variable...)
 
 /*!
  * \brief PostingJob is an active object that will do a posting job
@@ -120,8 +120,8 @@ class PostingJob : public QObject
     uint      _nbArticlesTotal;    //!< number of Articles of all the files to post
 
 
-    QAtomicBool _stopPosting;
-    QAtomicBool _noMoreFiles;
+    AtomicBool  _stopPosting;
+    AtomicBool  _noMoreFiles;
 
     bool _postStarted;
     bool _packed;
@@ -131,7 +131,7 @@ class PostingJob : public QObject
     const bool _obfuscateFileName;
 
 
-    QAtomicBool _delFilesAfterPost;
+    AtomicBool  _delFilesAfterPost;
     const QFileInfoList _originalFiles;
 
 

src/hmi/PostingWidget.cpp

@@ -102,6 +102,11 @@ void PostingWidget::onArticlesNumber(int nbArticles)
 
 void PostingWidget::onPostingJobDone()
 {
+    // we could arrive here twice: from PostingJob::postingFinished or PostingJob::noMoreConnection
+    // This could happen especially when we exceed the number of connections allowed by a provider
+    if (!_postingJob)
+        return;
+
     if (_postingJob->nbArticlesTotal() > 0)
     {
         if (_postingJob->nbArticlesFailed() > 0)
@@ -112,6 +117,7 @@ void PostingWidget::onPostingJobDone()
     else
         _hmi->clearJobTab(this);
 
+    disconnect(_postingJob);
     _postingJob = nullptr; //!< we don't own it, NgPost will delete it
     _postingFinished = true;
     setIDLE();