Skip to content

Commit dd16a48

Browse files
committed
Removed the "emit widgetChanged()" from all initializeUsingXML code
The order of the XML elements may be different to the order of the dependencies of corresponding GUI widgets. E.g. <generalizedInitialPosition> comes before <stateDependentTranslation> but the "generalized initial position" widget depends on the "state dependent translation" (the vector length of inipos depends on the defined translation element) For this reason after initializeUsingXML no widgetChange signal can be emitted.
1 parent a255af8 commit dd16a48

File tree

4 files changed

+3
-14
lines changed

4 files changed

+3
-14
lines changed

mbsimgui/mbsimgui/basic_widgets.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -352,7 +352,6 @@ namespace MBSimGUI {
352352
value->blockSignals(true);
353353
setValue(boost::lexical_cast<int>(X()%text->getData()));
354354
value->blockSignals(false);
355-
emit widgetChanged();
356355
return element;
357356
}
358357
return nullptr;

mbsimgui/mbsimgui/extended_widgets.cc

Lines changed: 3 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -197,9 +197,7 @@ namespace MBSimGUI {
197197
comboBox->blockSignals(true);
198198
comboBox->setCurrentIndex(k);
199199
comboBox->blockSignals(false);
200-
auto ret = widget->initializeUsingXML(e);
201-
emit widgetChanged();
202-
return ret;
200+
return widget->initializeUsingXML(e);
203201
}
204202
}
205203
else if (mode<=3) {
@@ -212,9 +210,7 @@ namespace MBSimGUI {
212210
comboBox->blockSignals(true);
213211
comboBox->setCurrentIndex(i);
214212
comboBox->blockSignals(false);
215-
auto ret = widget->initializeUsingXML(e);
216-
emit widgetChanged();
217-
return ret;
213+
return widget->initializeUsingXML(e);
218214
}
219215
}
220216
}
@@ -226,10 +222,8 @@ namespace MBSimGUI {
226222
comboBox->blockSignals(true);
227223
comboBox->setCurrentIndex(i);
228224
comboBox->blockSignals(false);
229-
if(widget->initializeUsingXML(element)) {
230-
emit widgetChanged();
225+
if(widget->initializeUsingXML(element))
231226
return element;
232-
}
233227
}
234228
}
235229
return nullptr;
@@ -409,7 +403,6 @@ namespace MBSimGUI {
409403
}
410404
list->blockSignals(false);
411405
spinBox->blockSignals(false);
412-
emit widgetChanged();
413406
return element;
414407
}
415408

mbsimgui/mbsimgui/function_widgets.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,6 @@ namespace MBSimGUI {
310310
updateFunctionFactory();
311311
fo->getWidget()->blockSignals(false);
312312
fo->initializeUsingXML(element);
313-
emit widgetChanged();
314313
return element;
315314
}
316315

mbsimgui/mbsimgui/special_widgets.cc

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ namespace MBSimGUI {
109109
e=e->getNextElementSibling();
110110
}
111111
}
112-
emit widgetChanged();
113112
return element;
114113
}
115114

@@ -200,7 +199,6 @@ namespace MBSimGUI {
200199
e=e->getNextElementSibling();
201200
}
202201
}
203-
emit widgetChanged();
204202
return element;
205203
}
206204

0 commit comments

Comments
 (0)