Skip to content

Commit d1ec371

Browse files
committed
Clean up comments and paths.
1 parent 32dddbe commit d1ec371

File tree

1 file changed

+5
-17
lines changed

1 file changed

+5
-17
lines changed

crates/iceberg/src/arrow/caching_delete_file_loader.rs

Lines changed: 5 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -687,8 +687,9 @@ mod tests {
687687
assert!(result.is_none()); // no pos dels for file 3
688688
}
689689

690-
/// Test loading a FileScanTask with BOTH positional and equality deletes.
691-
/// Verifies the fix for the inverted condition that caused "Missing predicate for equality delete file" errors.
690+
/// Test loading a FileScanTask with both positional and equality deletes.
691+
/// Verifies the fix for the inverted condition that caused "Missing predicate for equality
692+
/// delete file" errors first encountered when running Iceberg Java's TestSparkExecutorCache
692693
#[tokio::test]
693694
async fn test_load_deletes_with_mixed_types() {
694695
use crate::scan::FileScanTask;
@@ -701,28 +702,16 @@ mod tests {
701702
.build()
702703
.unwrap();
703704

704-
// Create the data file schema
705705
let data_file_schema = Arc::new(
706706
Schema::builder()
707707
.with_fields(vec![
708-
crate::spec::NestedField::optional(
709-
2,
710-
"y",
711-
crate::spec::Type::Primitive(crate::spec::PrimitiveType::Long),
712-
)
713-
.into(),
714-
crate::spec::NestedField::optional(
715-
3,
716-
"z",
717-
crate::spec::Type::Primitive(crate::spec::PrimitiveType::Long),
718-
)
719-
.into(),
708+
NestedField::optional(2, "y", Type::Primitive(PrimitiveType::Long)).into(),
709+
NestedField::optional(3, "z", Type::Primitive(PrimitiveType::Long)).into(),
720710
])
721711
.build()
722712
.unwrap(),
723713
);
724714

725-
// Write positional delete file
726715
let positional_delete_schema = crate::arrow::delete_filter::tests::create_pos_del_schema();
727716
let file_path_values =
728717
vec![format!("{}/data-1.parquet", table_location.to_str().unwrap()); 4];
@@ -751,7 +740,6 @@ mod tests {
751740
writer.write(&positional_deletes_to_write).unwrap();
752741
writer.close().unwrap();
753742

754-
// Write equality delete file
755743
let eq_delete_path = setup_write_equality_delete_file_1(table_location.to_str().unwrap());
756744

757745
// Create FileScanTask with BOTH positional and equality deletes

0 commit comments

Comments
 (0)