Skip to content

Commit 57b5928

Browse files
committed
make mapreduce pass on kwargs
1 parent 9130e91 commit 57b5928

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

src/functions.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ tuple_flatten(x::Tuple, ys::Tuple...) = (x..., tuple_flatten(ys...)...)
3636
tuple_flatten() = ()
3737

3838
function Base.mapreduce(f, op, A::KeyedArray; dims=:, kwargs...) # sum, prod, etc
39-
dims === Colon() && return mapreduce(f, op, parent(A))
39+
dims === Colon() && return mapreduce(f, op, parent(A); kwargs...)
4040
numerical_dims = NamedDims.dim(A, dims)
4141
data = mapreduce(f, op, parent(A); dims=numerical_dims, kwargs...)
4242
new_keys = ntuple(d -> d in numerical_dims ? Base.OneTo(1) : axiskeys(A,d), ndims(A))

test/_functions.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,8 +60,12 @@ A3 = wrapdims(rand(Int8, 3,4,2), r='a':'c', c=2:5, p=[10.0, 20.0])
6060
@test reshape(M, (4,3)) isa Array
6161
@test reshape(M, (2,:)) isa Array
6262
end
63-
6463
end
64+
@testset "Regression test against https://github.com/mcabbott/AxisKeys.jl/issues/43" begin
65+
z = KeyedArray(zeros(3); foo=[:a, :b, :c])
66+
@test mapreduce(identity, +, z; init=10) == 10
67+
end
68+
6569
@testset "sort" begin
6670

6771
@test sort(V)(20) == V(20)

0 commit comments

Comments
 (0)