Skip to content

Commit 742b600

Browse files
committed
pass kwargs on for statistics functions
1 parent 44e2320 commit 742b600

File tree

3 files changed

+8
-3
lines changed

3 files changed

+8
-3
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "AxisKeys"
22
uuid = "94b1ba4f-4ee9-5380-92f1-94cde586c3c5"
33
license = "MIT"
4-
version = "0.1.11"
4+
version = "0.1.12"
55

66
[deps]
77
AbstractFFTs = "621f4979-c628-5d54-868e-fcf4e3e8185c"

src/functions.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ end
4646
using Statistics
4747
for fun in [:mean, :std, :var] # These don't use mapreduce, but could perhaps be handled better?
4848
@eval function Statistics.$fun(A::KeyedArray; dims=:, kwargs...)
49-
dims === Colon() && return $fun(parent(A))
49+
dims === Colon() && return $fun(parent(A); kwargs...)
5050
numerical_dims = NamedDims.dim(A, dims)
5151
data = $fun(parent(A); dims=numerical_dims, kwargs...)
5252
new_keys = ntuple(d -> d in numerical_dims ? Base.OneTo(1) : axiskeys(A,d), ndims(A))
@@ -57,7 +57,7 @@ end
5757
# Handle function interface for `mean` only
5858
if VERSION >= v"1.3"
5959
@eval function Statistics.mean(f, A::KeyedArray; dims=:, kwargs...)
60-
dims === Colon() && return mean(f, parent(A))
60+
dims === Colon() && return mean(f, parent(A); kwargs...)
6161
numerical_dims = NamedDims.dim(A, dims)
6262
data = mean(f, parent(A); dims=numerical_dims, kwargs...)
6363
new_keys = ntuple(d -> d in numerical_dims ? Base.OneTo(1) : axiskeys(A,d), ndims(A))

test/_functions.jl

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,11 @@ end
6464
@testset "Regression test against https://github.com/mcabbott/AxisKeys.jl/issues/43" begin
6565
z = KeyedArray(zeros(3); foo=[:a, :b, :c])
6666
@test mapreduce(identity, +, z; init=10) == 10
67+
68+
m = KeyedArray([1, 2, 3]; foo=[:a, :b, :c])
69+
@test std(m; corrected=false) == std([1, 2, 3]; corrected=false)
70+
71+
6772
end
6873

6974
@testset "sort" begin

0 commit comments

Comments
 (0)