Skip to content

Commit dbed237

Browse files
author
Michael Abbott
committed
fixup axes for 1.0
1 parent 2d9c6b2 commit dbed237

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

src/LazyStack.jl

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,13 @@ ndims(A) = Base.ndims(A)
88
ndims(::Tuple) = 1
99
ndims(::NamedTuple) = 1
1010

11+
axes(A) = Base.axes(A)
12+
axes(A, d) = Base.axes(A, d)
13+
if VERSION < v"1.1" # because, on Julia 1.0, axes((1,2)) === Base.OneTo(2)
14+
axes(t::Tuple) = tuple(Base.axes(t))
15+
end
16+
axes(nt::NamedTuple) = tuple(Base.OneTo(length(nt)))
17+
1118
size(A) = Base.size(A)
1219
size(t::Tuple) = tuple(length(t))
1320
size(t::NamedTuple) = tuple(length(t))
@@ -80,9 +87,6 @@ Base.size(x::Stacked) = (size(first(x.slices))..., size(x.slices)...)
8087
Base.size(x::Stacked{T,N,<:Tuple}) where {T,N} = (size(first(x.slices))..., length(x.slices))
8188

8289
Base.axes(x::Stacked) = (axes(first(x.slices))..., axes(x.slices)...)
83-
if VERSION < v"1.1" # axes((1:9, 1:9)) == Base.OneTo(2) # on Julia 1.0
84-
Base.axes(x::Stacked{T,N,<:Tuple}) where {T,N} = (axes(first(x.slices))..., axes(x.slices))
85-
end
8690

8791
Base.parent(x::Stacked) = x.slices
8892

test/runtests.jl

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ using OffsetArrays, NamedDims
1818
@test stack(v34)[1,1,1] == v34[1][1] # trailing dims
1919
@test stack(v34) * ones(4) hcat(v34...) * ones(4) # issue #6
2020
@test stack(v34) * ones(4,2) hcat(v34...) * ones(4,2)
21+
@test axes(stack(v34)) === axes(stack(v34...)) === axes(stack(v34[i] for i in 1:4))
2122

2223
end
2324
@testset "tuples" begin
@@ -211,6 +212,21 @@ end
211212

212213
@test dimnames(rstack(:b, NamedDimsArray(1:2, :a), OffsetArray([2,3], +1))) == (:a, :b)
213214

215+
end
216+
@testset "tuple functions" begin
217+
218+
@test LazyStack.ndims([1,2]) == 1
219+
@test LazyStack.ndims((1,2)) == 1
220+
@test LazyStack.ndims((a=1,b=2)) == 1
221+
222+
@test LazyStack.size([1,2]) == (2,)
223+
@test LazyStack.size((1,2)) == (2,)
224+
@test LazyStack.size((a=1,b=2)) == (2,)
225+
226+
@test LazyStack.axes([1,2]) == (1:2,)
227+
@test LazyStack.axes((1,2)) == (1:2,)
228+
@test LazyStack.axes((a=1,b=2)) == (1:2,)
229+
214230
end
215231
@info "loading Zygote"
216232
using Zygote

0 commit comments

Comments
 (0)