fix #15

Author: mcabbott

Project.toml

@@ -1,7 +1,7 @@
 name = "LazyStack"
 uuid = "1fad7336-0346-5a1a-a56f-a06ba010965b"
 authors = ["Michael Abbott"]
-version = "0.1.0"
+version = "0.1.1"
 
 [deps]
 ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"

src/LazyStack.jl

@@ -87,7 +87,11 @@ lazystack(xs::AbstractArray{IT,ON}) where {IT<:AbstractArray{T,IN}} where {T,IN,
     stack_slices(xs, Val(T), Val(IN+ON))
 lazystack(xs::Tuple{Vararg{AbstractArray{T,IN}}}) where {T,IN} =
     stack_slices(xs, Val(T), Val(IN+1))
+
+# This lets `lazystack([1,2], [3,4])` act like hcat, slightly dodgy?
 lazystack(xs::AbstractArray{T}...) where {T} = lazystack(xs)
+# But `lazystack([1,2])` should not do this, violates equivalence with `Base.stack`.
+lazystack(xs::AbstractArray{<:Number}) = xs
 
 function stack_slices(xs::AT, ::Val{T}, ::Val{N}) where {T,N,AT}
     length(xs) >= 1 || throw(ArgumentError("stacking an empty collection is not allowed"))

test/runtests.jl

@@ -30,8 +30,13 @@ end
     @test lazystack(vt) == reshape(1:6, 2,3)
     @test lazystack(vnt) isa Array
 
-    @test lazystack(vt...) isa Array
-    @test lazystack(vnt...) isa Array
+    @test lazystack(vt...) isa Matrix
+    @test lazystack(vnt...) isa Matrix
+
+    lazystack((1,2)) isa Matrix  # case of 1, but do we want this? Not sure
+
+    @test lazystack([1,2], [3,4], [5,6]) isa AbstractMatrix
+    @test lazystack([1,2]) isa Vector  # NB to match Base.stack, https://github.com/mcabbott/LazyStack.jl/issues/15
 
 end
 @testset "generators" begin