support extended ASCII filenames, handle hidden/system files

Author: mcaldwelva

src/utility/FatStructs.h

@@ -413,6 +413,6 @@ static inline uint8_t DIR_IS_SUBDIR(const dir_t* dir) {
 }
 /** Directory entry is for a file or subdirectory */
 static inline uint8_t DIR_IS_FILE_OR_SUBDIR(const dir_t* dir) {
-  return (dir->attributes & DIR_ATT_VOLUME_ID) == 0;
+  return (dir->attributes & (DIR_ATT_VOLUME_ID | DIR_ATT_SYSTEM | DIR_ATT_HIDDEN)) == 0;
 }
 #endif  // FatStructs_h

src/utility/SdFat.h

@@ -437,7 +437,7 @@ class SdFile : public Print {
 
     // private data
     uint8_t   flags_;         // See above for definition of flags_ bits
-    uint8_t   type_;          // type of file see above for values
+    uint8_t   volatile type_; // type of file see above for values
     uint32_t  curCluster_;    // cluster for current file position
     uint32_t  curPosition_;   // current file position in bytes from beginning
     uint32_t  dirBlock_;      // SD block that contains directory entry for file

src/utility/SdFile.cpp

@@ -303,19 +303,19 @@ uint8_t SdFile::make83Name(const char* str, uint8_t* name) {
       // illegal FAT characters
       uint8_t b;
       #if defined(__AVR__)
-      PGM_P p = PSTR("|<>^+=?/[];,*\"\\");
+      PGM_P p = PSTR("|<>:+=?/[];,*\"\\");
       while ((b = pgm_read_byte(p++))) if (b == c) {
           return false;
         }
       #elif defined(__arm__)
-      const uint8_t valid[] = "|<>^+=?/[];,*\"\\";
+      const uint8_t valid[] = "|<>:+=?/[];,*\"\\";
       const uint8_t *p = valid;
       while ((b = *p++)) if (b == c) {
           return false;
         }
       #endif
       // check size and only allow ASCII printable characters
-      if (i > n || c < 0X21 || c > 0X7E) {
+      if (i > n || c < 0x20 || c == 0x7F) {
         return false;
       }
       // only upper case allowed in 8.3 names - convert lower to upper
@@ -1041,7 +1041,7 @@ uint8_t SdFile::rmRfStar(void) {
     }
 
     // skip if part of long file name or volume label in root
-    if (!DIR_IS_FILE_OR_SUBDIR(p)) {
+    if (p->attributes & DIR_ATT_VOLUME_ID) {
       continue;
     }