fix(handlers): use correct data types for sonar and cobertura attributes (#233)

Author: mcarvin8

baselines/cobertura_baseline.xml

@@ -7,7 +7,7 @@
   <packages>
     <package name="force-app" line-rate="0.871" branch-rate="1">
       <classes>
-        <class name="AccountProfile" filename="force-app/main/default/classes/AccountProfile.cls" line-rate="0.8710" branch-rate="1">
+        <class name="AccountProfile" filename="force-app/main/default/classes/AccountProfile.cls" line-rate="0.871" branch-rate="1">
           <methods/>
           <lines>
             <line number="52" hits="0" branch="false"/>
@@ -47,7 +47,7 @@
     </package>
     <package name="packaged" line-rate="0.871" branch-rate="1">
       <classes>
-        <class name="AccountTrigger" filename="packaged/triggers/AccountTrigger.trigger" line-rate="0.8710" branch-rate="1">
+        <class name="AccountTrigger" filename="packaged/triggers/AccountTrigger.trigger" line-rate="0.871" branch-rate="1">
           <methods/>
           <lines>
             <line number="52" hits="0" branch="false"/>

src/handlers/cobertura.ts

@@ -54,8 +54,8 @@ export class CoberturaCoverageHandler extends BaseHandler {
     const classObj: CoberturaClass = {
       '@name': fileName,
       '@filename': filePath,
-      '@line-rate': '0',
-      '@branch-rate': '1',
+      '@line-rate': 0,
+      '@branch-rate': 1,
       methods: {},
       lines: { line: [] },
     };
@@ -69,7 +69,7 @@ export class CoberturaCoverageHandler extends BaseHandler {
     }
 
     if (totalLines > 0) {
-      classObj['@line-rate'] = (coveredLines / totalLines).toFixed(4);
+      classObj['@line-rate'] = parseFloat((coveredLines / totalLines).toFixed(4));
     }
 
     this.coverageObj.coverage['@lines-valid'] += totalLines;
@@ -83,10 +83,7 @@ export class CoberturaCoverageHandler extends BaseHandler {
     this.coverageObj.coverage.packages.package = Array.from(this.packageMap.values());
 
     for (const pkg of this.coverageObj.coverage.packages.package) {
-      const totalLines = pkg.classes.class.reduce(
-        (sum, cls) => sum + parseFloat(cls['@line-rate']) * cls.lines.line.length,
-        0
-      );
+      const totalLines = pkg.classes.class.reduce((sum, cls) => sum + cls['@line-rate'] * cls.lines.line.length, 0);
       const totalClasses = pkg.classes.class.reduce((sum, cls) => sum + cls.lines.line.length, 0);
 
       pkg['@line-rate'] = parseFloat((totalLines / totalClasses).toFixed(4));

src/handlers/sonar.ts

@@ -25,7 +25,7 @@ export class SonarCoverageHandler extends BaseHandler {
       lineToCover: [],
     };
     for (const [lineNumberString, value] of Object.entries(lines)) {
-      const covered = value === 1 ? 'true' : 'false';
+      const covered = value === 1;
       fileObj.lineToCover.push({
         '@lineNumber': Number(lineNumberString),
         '@covered': covered,

src/utils/types.ts

@@ -46,7 +46,7 @@ export type CoverageProcessingContext = {
 
 type SonarLine = {
   '@lineNumber': number;
-  '@covered': string;
+  '@covered': boolean;
 };
 
 export type SonarClass = {
@@ -78,8 +78,8 @@ export type CoberturaLine = {
 export type CoberturaClass = {
   '@name': string;
   '@filename': string;
-  '@line-rate': string;
-  '@branch-rate': string;
+  '@line-rate': number;
+  '@branch-rate': number;
   methods: Record<string, never>;
   lines: {
     line: CoberturaLine[];