Moving the logic for trade manager out of the header file into the source

Author: mccaffers

.github/workflows/sonarcloud.yml

@@ -17,20 +17,36 @@ jobs:
 
   build:
     name: Build & Test
-    runs-on: macos-14
+    runs-on: macos-14  # Use macOS 14 (Sonoma) runner
+
     steps:
-    - uses: actions/checkout@v4
+    # Step 1: Check out the repository code
+    - name: Checkout repository
+      uses: actions/checkout@v4
+
+    # Step 2: Set up Homebrew package manager
     - name: Set up Homebrew
       id: set-up-homebrew
       uses: Homebrew/actions/setup-homebrew@master
-    - name: Install packages
-      run: >
-          bash ./.github/workflows/brew.sh
-    - name: Build libraries
-      run: >
-          bash ./.github/workflows/build.sh
-    - name: Select Xcode  
-      run: sudo xcode-select -switch /Applications/Xcode_15.2.app && /usr/bin/xcodebuild -version
+
+    # Step 3: Install required dependencies using Homebrew
+    - name: Install dependencies
+      run: bash ./.github/workflows/brew.sh
+
+    # Step 4: Build project external libraries
+    - name: Build C++ Libraries
+      run: bash ./.github/workflows/build.sh
+
+    # Step 5: Configure Xcode version
+    - name: Select Xcode version
+      run: |
+        sudo xcode-select -switch /Applications/Xcode_15.2.app
+        /usr/bin/xcodebuild -version
+    # Run XCode tests with specific configurations:
+    # - Builds and runs the test suite
+    # - Generates code coverage reports
+    # - Uses PostgreSQL and libpqxx external dependencies
+    # - Outputs results in JUnit format
     - name: Run tests
       run: >
           CODE_SIGN_IDENTITY="" CODE_SIGNING_REQUIRED=NO
@@ -40,21 +56,30 @@ jobs:
           -resultBundlePath TestResult/ 
           -enableCodeCoverage YES 
           -derivedDataPath "${RUNNER_TEMP}/Build/DerivedData" 
-          HEADER_SEARCH_PATHS="./external/libpqxx/include/pqxx/internal ./external/libpqxx/include/ ./external/libpqxx/build/include/ ./external/" \
-          LIBRARY_SEARCH_PATHS="./external/libpqxx/src/ ./external/libpqxx/build/src/" \
+          GCC_GENERATE_TEST_COVERAGE_FILES=YES
+          GCC_INSTRUMENT_PROGRAM_FLOW_ARCS=YES
+          CLANG_COVERAGE_MAPPING=YES
+          CLANG_COVERAGE_MAPPING_LINKER_ARGS=YES
+          DEBUG_INFORMATION_FORMAT="dwarf-with-dsym"
+          BUILD_LIBRARY_FOR_DISTRIBUTION=NO
+          HEADER_SEARCH_PATHS="./external/libpqxx/include/pqxx/internal ./external/libpqxx/include/ ./external/libpqxx/build/include/ ./external/"
+          LIBRARY_SEARCH_PATHS="./external/libpqxx/src/ ./external/libpqxx/build/src/"
           OTHER_LDFLAGS="-L./external/libpqxx/build/src -lpqxx -lpq -L/opt/homebrew/Cellar/pkgconf/2.3.0_1/lib -L/opt/homebrew/Cellar/pkgconf/2.3.0_1/lib/pkgconfig -L/opt/homebrew/Cellar/postgresql@14/14.15/lib/postgresql@14 -L/opt/homebrew/Cellar/postgresql@14/14.15/lib/postgresql@14/pgxs -L/opt/homebrew/Cellar/postgresql@14/14.15/lib/postgresql@14/pkgconfig"
-          clean build test  
+          clean build test
           | xcpretty -r junit && exit ${PIPESTATUS[0]}
     - name: Convert coverage report to sonarqube format
       run: >
           bash ./.github/workflows/xccov-to-sonarqube-generic.sh *.xcresult/ > sonarqube-generic-coverage.xml
+    # Artifact will be available only for 1 day, this is because 
+    # it's only used to pass test data to SonarCloud only
     - name: Upload coverage report
       uses: actions/upload-artifact@v4
       with:
         path: sonarqube-generic-coverage.xml
         retention-days: 1 # Artifact will be available only for 5 days.
+        
   sonar-scan:    
-    name: Sonar scan
+    name: SonarCloud Scan
     runs-on: ubuntu-latest
     needs: build
     steps:
@@ -63,39 +88,52 @@ jobs:
         with:
           ref: ${{ github.HEAD_REF }}
           fetch-depth: 0       
-      - name: Check compiler version
+      - name: Check compiler version, for debugging
         run: |
           g++ --version
           cmake --version
-      - name: Build libraries
+      - name: Build C++ Libraries
         run: >
             bash ./.github/workflows/build.sh
-      - name: Set up Python 3.8 for gcovr
+      - name: Install Python 3.12 for gcovr
         uses: actions/setup-python@v5
         with: 
-          python-version: 3.8
-      - name: install gcovr 5.0
+          python-version: 3.12
+      # Gcovr provides a utility for managing the use of the GNU gcov utility and generating 
+      # summarized code coverage results. This command is inspired by the Python coverage.py 
+      # package, which provides a similar utility for Python.
+      # https://pypi.org/project/gcovr/
+      - name: Install gcovr
         run: |
-          pip install gcovr==5.0 # 5.1 is not supported by sonarcloud
-      - name: Install sonar-scanner and build-wrapper
-        uses: SonarSource/sonarcloud-github-c-cpp@v3   
+          pip install gcovr==8.3
+      # SonarQube Server and Cloud (formerly SonarQube and SonarCloud) is a widely used static 
+      # analysis solution for continuous code quality and security inspection.
+      # This action now supports and is the official entrypoint for scanning C++ projects via GitHub actions.
+      # https://github.com/SonarSource/sonarqube-scan-action
+      - name: Install Build Wrapper
+        uses: SonarSource/sonarqube-scan-action/[email protected] 
+        # This step installs the SonarQube build wrapper, which is necessary for analyzing C/C++ projects.
+      
+      # Downloads all artifacts generated by previous steps in the workflow
       - name: Download all workflow run artifacts
         uses: actions/download-artifact@v4
-      - name: Unpack Artifact  
-        run: >
-          ls -l ./
+      
+      # Configures the CMake build system, specifying the source directory and build directory, and setting the build type
       - name: Configure CMake
-        # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
-      #  See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
         run: cmake -S ${{github.workspace}} -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}}
+      
+      # Runs the build wrapper to capture build commands and outputs them to the specified directory. Then builds the project using CMake
       - name: Run build-wrapper
         run: |
           build-wrapper-linux-x86-64 --out-dir ${{ env.BUILD_WRAPPER_OUT_DIR }} cmake --build ${{github.workspace}}/build --config ${{env.BUILD_TYPE}}
-      - name: Run sonar-scanner
+      
+      # Performs the SonarQube scan using the scan action. Uses captured build commands for analysis and requires GitHub and SonarQube tokens for authentication
+      - name: SonarQube Scan
+        uses: SonarSource/[email protected]
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN  }} # Put the name of your token here
-        run: |
-          sonar-scanner \
-          --define sonar.cfamily.build-wrapper-output="${{ env.BUILD_WRAPPER_OUT_DIR }}" \
-          -Dsonar.coverageReportPaths=artifact/sonarqube-generic-coverage.xml
+          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN  }} 
+        with:
+          args: >
+            --define sonar.cfamily.compile-commands="${{ env.BUILD_WRAPPER_OUT_DIR }}/compile_commands.json"
+            --define sonar.coverageReportPaths=artifact/sonarqube-generic-coverage.xml

.gitignore

@@ -37,4 +37,6 @@ TestResult
 .DS_Store
 
 xcuserdata/
-xcuserstate/
+xcuserstate/
+TestResult.xcresult/
+sonarqube-generic-coverage.xml