fix: make onboarding E2E test more robust against redirect timing

Uses Promise.race to wait for either the sign-in button (home page after
redirect) or the onboarding wizard heading, eliminating race conditions
with URL-based checks during server-side redirects.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <[email protected]>

Author: mchestr

e2e/public-flows.spec.ts

@@ -51,20 +51,31 @@ test.describe('Public Flows', () => {
   });
 
   test('onboarding page accessibility check', async ({ page }) => {
-
     await page.goto('/onboarding');
 
-    const isHome = page.url().endsWith('/');
-    const isSignin = page.url().includes('signin');
-    const isOnboarding = page.url().includes('/onboarding');
-
-    if (isOnboarding) {
-      // If we stay on onboarding, verify the wizard is visible
-      await expect(page.getByTestId('onboarding-wizard-heading')).toBeVisible();
-      await expect(page.getByTestId('onboarding-wizard-subheading')).toBeVisible();
-    } else {
-      // If redirected, ensure we are on a safe page
-      expect(isHome || isSignin).toBeTruthy();
+    // Unauthenticated users should be redirected to home
+    // Wait for either the sign-in button (home page) or the onboarding wizard
+    // Using waitForSelector with a race condition to handle either outcome
+    const signInButton = page.getByTestId('sign-in-button');
+    const onboardingHeading = page.getByTestId('onboarding-wizard-heading');
+
+    // Wait for either element to appear (whichever comes first)
+    await Promise.race([
+      signInButton.waitFor({ state: 'visible', timeout: WAIT_TIMEOUTS.PAGE_CONTENT }),
+      onboardingHeading.waitFor({ state: 'visible', timeout: WAIT_TIMEOUTS.PAGE_CONTENT }),
+    ]);
+
+    // After one element is visible, check which state we're in
+    const isOnHome = await signInButton.isVisible();
+    const isOnOnboarding = await onboardingHeading.isVisible();
+
+    // For unauthenticated users (the default in this test), we expect redirect to home
+    // For authenticated users with incomplete onboarding, we'd see the wizard
+    expect(isOnHome || isOnOnboarding).toBeTruthy();
+
+    if (isOnOnboarding) {
+      // Verify the subheading as well
+      await expect(page.getByTestId('onboarding-wizard-subheading')).toBeVisible({ timeout: WAIT_TIMEOUTS.PAGE_CONTENT });
     }
   });