fix: address PR feedback - accessibility and centralized logging

- Add aria-label to toggle buttons for screen reader accessibility
- Replace console.error with centralized logger in watchlist actions

Co-Authored-By: Claude <[email protected]>

Author: mchestr

actions/admin/watchlist.ts

@@ -3,10 +3,13 @@
 import { authOptions } from "@/lib/auth"
 import { prisma } from "@/lib/prisma"
 import { requireAdmin } from "@/lib/admin"
+import { createLogger } from "@/lib/utils/logger"
 import { globalWatchlistSyncSettingsSchema } from "@/lib/validations/watchlist"
 import { syncUserWatchlist } from "@/lib/watchlist/sync-service"
 import { getServerSession } from "next-auth"
 
+const logger = createLogger("ADMIN_WATCHLIST_ACTIONS")
+
 /**
  * Get global watchlist sync settings (admin only)
  */
@@ -33,7 +36,7 @@ export async function getGlobalWatchlistSyncSettings() {
       },
     }
   } catch (error) {
-    console.error("Error fetching global watchlist sync settings:", error)
+    logger.error("Error fetching global watchlist sync settings", error)
     return { success: false as const, error: "Failed to fetch settings" }
   }
 }
@@ -86,7 +89,7 @@ export async function updateGlobalWatchlistSyncSettings(data: unknown) {
 
     return { success: true as const }
   } catch (error) {
-    console.error("Error updating global watchlist sync settings:", error)
+    logger.error("Error updating global watchlist sync settings", error)
     return { success: false as const, error: "Failed to update settings" }
   }
 }
@@ -136,7 +139,7 @@ export async function getWatchlistSyncStats() {
       },
     }
   } catch (error) {
-    console.error("Error fetching watchlist sync stats:", error)
+    logger.error("Error fetching watchlist sync stats", error)
     return { success: false as const, error: "Failed to fetch stats" }
   }
 }
@@ -173,7 +176,7 @@ export async function forceUserWatchlistSync(userId: string) {
       data: result.data,
     }
   } catch (error) {
-    console.error("Error forcing user watchlist sync:", error)
+    logger.error("Error forcing user watchlist sync", error)
     return { success: false as const, error: "Failed to sync" }
   }
 }

actions/watchlist.ts

@@ -2,11 +2,14 @@
 
 import { WatchlistSyncStatus } from "@/lib/generated/prisma/client"
 import { prisma } from "@/lib/prisma"
+import { createLogger } from "@/lib/utils/logger"
 import { updateWatchlistSyncSettingsSchema } from "@/lib/validations/watchlist"
 import { syncUserWatchlist } from "@/lib/watchlist/sync-service"
 import { getServerSession } from "next-auth"
 import { authOptions } from "@/lib/auth"
 
+const logger = createLogger("WATCHLIST_ACTIONS")
+
 /**
  * Get current user's watchlist sync settings and status
  */
@@ -86,7 +89,7 @@ export async function getWatchlistSyncSettings() {
       },
     }
   } catch (error) {
-    console.error("Error fetching watchlist sync settings:", error)
+    logger.error("Error fetching watchlist sync settings", error)
     return { success: false as const, error: "Failed to fetch settings" }
   }
 }
@@ -159,7 +162,7 @@ export async function updateWatchlistSyncSettings(data: unknown) {
 
     return { success: true as const }
   } catch (error) {
-    console.error("Error updating watchlist sync settings:", error)
+    logger.error("Error updating watchlist sync settings", error)
     return { success: false as const, error: "Failed to update settings" }
   }
 }
@@ -195,7 +198,7 @@ export async function triggerWatchlistSync() {
       data: result.data,
     }
   } catch (error) {
-    console.error("Error triggering watchlist sync:", error)
+    logger.error("Error triggering watchlist sync", error)
     return { success: false as const, error: "Failed to trigger sync" }
   }
 }
@@ -251,7 +254,7 @@ export async function getWatchlistSyncHistory(options?: {
       },
     }
   } catch (error) {
-    console.error("Error fetching watchlist sync history:", error)
+    logger.error("Error fetching watchlist sync history", error)
     return { success: false as const, error: "Failed to fetch history" }
   }
 }

components/admin/settings/watchlist-sync-settings.tsx

@@ -157,6 +157,7 @@ export function WatchlistSyncSettings() {
             `}
             role="switch"
             aria-checked={settings.watchlistSyncEnabled}
+            aria-label={settings.watchlistSyncEnabled ? "Disable watchlist sync" : "Enable watchlist sync"}
             data-testid="watchlist-sync-global-toggle"
           >
             <span

components/watchlist/sync-settings-card.tsx

@@ -202,6 +202,7 @@ export function WatchlistSyncCard() {
             `}
             role="switch"
             aria-checked={isEnabled}
+            aria-label={isEnabled ? "Disable watchlist sync" : "Enable watchlist sync"}
             data-testid="watchlist-sync-toggle"
           >
             <span