Skip to content

Commit e7c3c54

Browse files
committed
docs: unify helm commands and add tolerations example
1 parent 32a1eda commit e7c3c54

File tree

1 file changed

+19
-13
lines changed

1 file changed

+19
-13
lines changed

README.md

Lines changed: 19 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,9 +10,21 @@ By default, `kubeadm` enables the NodeRestriction admission controller that rest
1010

1111
### Helm (recommended)
1212

13+
`helm upgrade --install` works for both fresh installs and upgrades:
14+
15+
```shell
16+
helm upgrade --install node-role-controller \
17+
oci://ghcr.io/mchmarny/node-role-controller \
18+
-n node-role-controller --create-namespace
19+
```
20+
21+
To schedule on tainted nodes, add tolerations:
22+
1323
```shell
14-
helm install node-role-controller oci://ghcr.io/mchmarny/node-role-controller \
15-
--namespace node-labeler --create-namespace
24+
helm upgrade --install node-role-controller \
25+
oci://ghcr.io/mchmarny/node-role-controller \
26+
-n node-role-controller --create-namespace \
27+
--set-json 'tolerations=[{"key":"dedicated","value":"system-workload","operator":"Equal","effect":"NoExecute"},{"key":"dedicated","value":"system-workload","operator":"Equal","effect":"NoSchedule"}]'
1628
```
1729

1830
### Manifest
@@ -32,8 +44,9 @@ kubectl apply -k deployment/overlays/prod
3244
The controller is configured via environment variables sourced from a ConfigMap. With Helm, set values directly:
3345

3446
```shell
35-
helm install node-role-controller oci://ghcr.io/mchmarny/node-role-controller \
36-
--namespace node-labeler --create-namespace \
47+
helm upgrade --install node-role-controller \
48+
oci://ghcr.io/mchmarny/node-role-controller \
49+
-n node-role-controller --create-namespace \
3750
--set config.roleLabel=nodeGroup \
3851
--set config.roleReplace=true \
3952
--set config.logLevel=debug
@@ -53,19 +66,12 @@ helm install node-role-controller oci://ghcr.io/mchmarny/node-role-controller \
5366
| `tolerations` | `[]` | Pod tolerations |
5467
| `nodeSelector` | `{}` | Pod node selector |
5568

56-
> After changing configuration, restart to apply: `kubectl -n node-labeler rollout restart deployment node-role-controller`
57-
58-
## Upgrade
59-
60-
```shell
61-
helm upgrade node-role-controller oci://ghcr.io/mchmarny/node-role-controller \
62-
--namespace node-labeler
63-
```
69+
> After changing configuration, restart to apply: `kubectl -n node-role-controller rollout restart deployment node-role-controller`
6470
6571
## Uninstall
6672

6773
```shell
68-
helm uninstall node-role-controller -n node-labeler
74+
helm uninstall node-role-controller -n node-role-controller
6975
```
7076

7177
## How It Works

0 commit comments

Comments
 (0)