Merge pull request #82 from mcintyre94/test-claude-behavior-issue-3b71887e

Fix quick chat blank response when Claude hits max-turns limit

Author: mcintyre94

Wisp/ViewModels/QuickChatViewModel.swift

@@ -60,7 +60,7 @@ final class QuickChatViewModel {
 
         var claudeCmd = "claude -p --verbose --output-format stream-json --dangerously-skip-permissions"
         claudeCmd += " --disallowedTools \"Bash,Write,Edit,MultiEdit,WebSearch,WebFetch\""
-        claudeCmd += " --max-turns 3"
+        claudeCmd += " --max-turns 5"
         claudeCmd += " --model \(modelId)"
         if let sid = sessionId {
             claudeCmd += " --resume \(sid)"
@@ -155,8 +155,13 @@ final class QuickChatViewModel {
                 }
             }
         case .result(let resultEvent):
-            if resultEvent.isError == true, response.isEmpty {
-                error = "Claude returned an error"
+            let isErrorResult = resultEvent.isError == true || (resultEvent.subtype != nil && resultEvent.subtype != "success")
+            if isErrorResult, response.isEmpty {
+                if resultEvent.subtype == "error_max_turns" {
+                    error = "Claude hit the turn limit without responding — try a simpler question"
+                } else {
+                    error = "Claude returned an error"
+                }
             }
         default:
             break

WispTests/QuickChatViewModelTests.swift

@@ -106,6 +106,30 @@ struct QuickChatViewModelTests {
         #expect(vm.error == nil)
     }
 
+    @Test func handle_maxTurnsResult_setsSpecificErrorWhenResponseEmpty() {
+        let vm = makeViewModel()
+        let event = ClaudeStreamEvent.result(ClaudeResultEvent(
+            type: "result", subtype: "error_max_turns",
+            sessionId: "sess-abc", isError: false,
+            durationMs: 100, numTurns: 3, result: nil
+        ))
+        vm.handle(event)
+        #expect(vm.error?.contains("turn limit") == true)
+    }
+
+    @Test func handle_maxTurnsResult_doesNotSetErrorWhenResponseNonEmpty() {
+        let vm = makeViewModel()
+        vm.handle(assistantEvent("Some partial answer"))
+        let event = ClaudeStreamEvent.result(ClaudeResultEvent(
+            type: "result", subtype: "error_max_turns",
+            sessionId: "sess-abc", isError: false,
+            durationMs: 100, numTurns: 3, result: nil
+        ))
+        vm.handle(event)
+        #expect(vm.error == nil)
+        #expect(vm.response == "Some partial answer")
+    }
+
     @Test func send_withNilSessionId_setsIsStreamingTrue() {
         let vm = makeViewModel(sessionId: nil)
         vm.question = "What files are here?"