Revert (amend to remove stupid ci cache)

Author: sailro

Packages/com.unity.ide.visualstudio/Editor/VisualStudioEditor.cs

@@ -228,22 +228,8 @@ public bool OpenProject(string path, int line, int column)
 			if (!IsProjectGeneratedFor(path, generator, out var missingFlag))
 				Debug.LogWarning($"You are trying to open {path} outside a generated project. This might cause problems with IntelliSense and debugging. To avoid this, you can change your .csproj preferences in Edit > Preferences > External Tools and enable {GetProjectGenerationFlagDescription(missingFlag)} generation.");
 
-			if (!generator.HasSolutionBeenGenerated())
-			{
-				// If no solution has been generated, run a sync before opening the solution
-				generator.Sync();
-				return OpenFromInstallation(installation, path, line, column);
-			}
-			else
-			{
-				// Else chances are high that the solution is up-to-date, proactively open the solution for better latency
-				var result = OpenFromInstallation(installation, path, line, column);
-				
-				// But run a sync to make sure everything is up-to-date. Best case we'll do nothing (apart from checking compilation objects), worst case VS will reload touched projects.
-				generator.Sync();
-
-				return result;
-			}
+			var solution = GetOrGenerateSolutionFile(generator);
+			return installation.Open(path, line, column, solution);
 		}
 
 		private static bool OpenFromInstallation(IVisualStudioInstallation installation, string path, int line, int column)
@@ -311,5 +297,11 @@ private static bool IsProjectGeneratedFor(string path, IGenerator generator, out
 			missingFlag = flag;
 			return false;
 		}
+
+		private static string GetOrGenerateSolutionFile(IGenerator generator)
+		{
+			generator.Sync();
+			return generator.SolutionFile();
+		}
 	}
 }