more corrections

Author: mcmonkey4eva

DenizenModelsConverter/BBModel.cs

@@ -51,6 +51,8 @@ public class Element
 
             public Face North, South, East, West, Up, Down;
 
+            public Outliner Outline;
+
             public class Face
             {
                 public int TextureID;
@@ -103,7 +105,9 @@ public class Animation
 
             public enum LoopType
             {
-                LOOP, ONCE
+                LOOP,
+                ONCE,
+                HOLD
             }
 
             public LoopType Loop;
@@ -148,7 +152,8 @@ public enum ChannelType
                 public enum InterpolationType
                 {
                     LINEAR,
-                    CATMULLROM
+                    CATMULLROM, // AKA "Smooth"
+                    STEP
                 }
 
                 public InterpolationType Interpolation;

DenizenModelsConverter/BBModelReader.cs

@@ -209,9 +209,15 @@ public static void AddOutlineChild(BBModel model, BBModel.Outliner outline, JTok
                     }
                     throw new Exception($"Cannot find required element {id} for outline {outline.Name}");
                 }
-                if (AcceptableRotations.Contains(element.Rotation.X) && AcceptableRotations.Contains(element.Rotation.Y) && AcceptableRotations.Contains(element.Rotation.Z))
+                if (element.Outline is not null)
+                {
+                    throw new Exception($"Cannot add required element {id} for outline {outline.Name} because it is already in other outline {element.Outline.Name}");
+                }
+                if (AcceptableRotations.Contains(element.Rotation.X) && AcceptableRotations.Contains(element.Rotation.Y) && AcceptableRotations.Contains(element.Rotation.Z)
+                    && ((element.Rotation.X == 0 ? 0 : 1) + (element.Rotation.Y == 0 ? 0 : 1) + (element.Rotation.Z == 0 ? 0 : 1)) < 2)
                 {
                     outline.Children.Add(id);
+                    element.Outline = outline;
                 }
                 else
                 {
@@ -224,6 +230,7 @@ public static void AddOutlineChild(BBModel model, BBModel.Outliner outline, JTok
                     };
                     element.Rotation = new DoubleVector();
                     element.Origin = new DoubleVector();
+                    element.Outline = specialSideOutline;
                     specialSideOutline.Children.Add(element.UUID);
                     model.Outlines.Add(specialSideOutline);
                     outline.Paired.Add(specialSideOutline.UUID);

DenizenModelsConverter/MinecraftModelMaker.cs

@@ -34,8 +34,8 @@ public static string CreateModelFor(BBModel model, BBModel.Outliner outline)
                     any = true;
                     JObject jElement = new();
                     jElement.Add("name", element.Name);
-                    jElement.Add("from", DVecToArray(element.From));
-                    jElement.Add("to", DVecToArray(element.To));
+                    jElement.Add("from", DVecToArray(element.From - outline.Origin));
+                    jElement.Add("to", DVecToArray(element.To - outline.Origin));
                     JObject rotation = new();
                     rotation.Add("origin", DVecToArray(element.Origin));
                     if (element.Rotation.X != 0)